OV-29: * remove as suggested in review all helpers of null and undefi…

…end values
BinaryStudioAcademy · Aug 23, 2024 · 80b0bcf · 80b0bcf
1 parent 634bdfb
commit 80b0bcf
Show file tree

Hide file tree

Showing 7 changed files with 2 additions and 30 deletions.
diff --git a/frontend/src/bundles/common/helpers/array-helper/array-helper.ts b/frontend/src/bundles/common/helpers/array-helper/array-helper.ts
diff --git a/frontend/src/bundles/common/helpers/array-helper/is-empty-array.ts b/frontend/src/bundles/common/helpers/array-helper/is-empty-array.ts
diff --git a/frontend/src/bundles/common/helpers/helpers.ts b/frontend/src/bundles/common/helpers/helpers.ts
@@ -1,4 +1 @@
-export { isEmptyArray } from './array-helper/array-helper.js';
-export { isNullOrUndefined } from './is-null-or-undefined/is-null-or-undefined.js';
-export { isStringNullOrEmpty } from './string-helpers/string-helper.js';
 export { configureString } from 'shared';
diff --git a/frontend/src/bundles/common/helpers/is-null-or-undefined/is-null-or-undefined.ts b/frontend/src/bundles/common/helpers/is-null-or-undefined/is-null-or-undefined.ts
diff --git a/frontend/src/bundles/common/helpers/string-helpers/is-null-or-undefined.ts b/frontend/src/bundles/common/helpers/string-helpers/is-null-or-undefined.ts
diff --git a/frontend/src/bundles/common/helpers/string-helpers/string-helper.ts b/frontend/src/bundles/common/helpers/string-helpers/string-helper.ts
diff --git a/frontend/src/bundles/video-editor/components/menu/menu.tsx b/frontend/src/bundles/video-editor/components/menu/menu.tsx
@@ -1,8 +1,4 @@
 import { Box, Flex, VStack } from '~/bundles/common/components/components.js';
-import {
-    isEmptyArray,
-    isNullOrUndefined,
-} from '~/bundles/common/helpers/helpers.js';
 import { useCallback } from '~/bundles/common/hooks/hooks.js';
 
 import { type MenuItem } from '../../types/types.js';
@@ -17,12 +13,12 @@ const Menu: React.FC<Properties> = ({ items, activeIndex, setActiveIndex }) => {
     const handleClick = useCallback(
         (index: number) => {
             return () => {
-                if (isEmptyArray(items) || index >= items.length) {
+                if (!items || items.length === 0 || index >= items.length) {
                     return;
                 }
 
                 const item = items[index];
-                if (isNullOrUndefined(item)) {
+                if (!item) {
                     return;
                 }