Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Add sidebar and header to Home page #75

Closed
1 of 2 tasks
Sanchousina opened this issue Aug 28, 2024 · 4 comments · Fixed by #83
Closed
1 of 2 tasks

FEAT: Add sidebar and header to Home page #75

Sanchousina opened this issue Aug 28, 2024 · 4 comments · Fixed by #83
Assignees
Labels
AC Feature has acceptance criteria FE Fronted feature

Comments

@Sanchousina
Copy link
Collaborator

Sanchousina commented Aug 28, 2024

What feature?

Integrate sidebar and header to the home page as shown on the design

Add screenshots

Image

Acceptance criteria

  • Home page should contain the header as designed in Figma.
  • Home page should contain the sidebar as designed in Figma.

Testing documentation

https://docs.google.com/spreadsheets/d/1OXXcyv94vEVQeGB3AaYqgremUU7FLdrxkUV6bz03S0g/edit?gid=1927397104#gid=1927397104

@Sanchousina Sanchousina added the FE Fronted feature label Aug 28, 2024
@stefano-lacorazza stefano-lacorazza self-assigned this Aug 28, 2024
@stefano-lacorazza stefano-lacorazza added this to the Release 1.0 milestone Aug 28, 2024
@stefano-lacorazza
Copy link
Collaborator

Hi, sorry but isnt the header component already implemented?

Image

@stefano-lacorazza stefano-lacorazza linked a pull request Aug 29, 2024 that will close this issue
@Sanchousina
Copy link
Collaborator Author

The header was already implemented, but you need to integrate it properly to the home page. As you can see, I already put empty header component, but if you would look on the design I provided, there also should be notification icon on the right

@stefano-lacorazza
Copy link
Collaborator

Ok done.

Image

@nikita-remeslov nikita-remeslov moved this from Peer Review to In Progress in bsa-2024-outreachvids Aug 30, 2024
@alien513 alien513 self-assigned this Sep 3, 2024
@github-project-automation github-project-automation bot moved this from Peer Review to To Be Tested in bsa-2024-outreachvids Sep 5, 2024
@alien513
Copy link
Collaborator

alien513 commented Sep 10, 2024

Sidebar and header were added to the Home page.

Image

@alien513 alien513 added AC Feature has acceptance criteria QA QA tasks and removed QA QA tasks labels Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AC Feature has acceptance criteria FE Fronted feature
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants