OV-75: add sidebar and header to home page #83
Conversation
stefano-lacorazza
requested review from
nikita-remeslov,
anton-otroshchenko and
sofiia-trokhymchuk
as code owners
|
Please change your target branch to task/OV-13-add-side-bar-component, so that we can see a valid diff. |
stefano-lacorazza
changed the base branch from
next
to
task/OV-62-create-avatar-page
|
I changed branch to task/OV-62 because the PR from branch 13 was closed and inthe issue i says the new branch is 62. https://github.com/orgs/BinaryStudioAcademy/projects/30/views/1?pane=issue&itemId=75054501 |
|
|
|
When there are new notifications, the bell icon should also have little orange circle (as in design) |
In Header task the bell icon is crossed. Maybe we should not implement it now? |
This reverts commit c03b5c1.
| Box, | ||
| Header, | ||
| Sidebar, | ||
| } from '~/bundles/common/components/components.js'; | ||
|
|
There was a problem hiding this comment.
Did you encounter this issue with the background? I think it should be entirely blue, not white at the end. I know Oleksandra created the homepage, but it would be better to fix it now since you're also working on the homepage.
There was a problem hiding this comment.
You just need to add the overflow: auto; property to the main wrapper.
Which left padding? |
|
The changes that you need are already in next, so you can change your base branch to next, because right now we cannot see valid diff. |
stefano-lacorazza
changed the base branch from
task/OV-62-create-avatar-page
to
next
stefano-lacorazza
dismissed stale reviews from Alblupynos, WilsonBravo, and o-nedashkivska
The base branch was changed.
| @@ -16,8 +16,7 @@ const Header: React.FC<Properties> = ({ left, center, right }) => { | |||
| left="0" | |||
| width="full" | |||
| backgroundColor="background.900" | |||
| boxShadow="md" | |||
| zIndex="100" | |||
| zIndex="1000" | |||
There was a problem hiding this comment.
Does zIndex="100" not work?
Because in this pr we changed it from 1000 to 100 :)
stefano-lacorazza
dismissed stale reviews from Alblupynos and anton-otroshchenko
via
474336d
stefano-lacorazza
requested review from
o-nedashkivska,
Alblupynos and
anton-otroshchenko
nikita-remeslov
deleted the
task/OV-75-Add-sidebar-and-header-to-Home-page
branch
Created branch from branch OV-62.
Proposed some changes of Sidebar in pull request #66 that could benefit this task