OV-1: Sign In flow #15
Conversation
o-nedashkivska
requested review from
nikita-remeslov,
anton-otroshchenko and
sofiia-trokhymchuk
as code owners
| }; | ||
|
|
||
| const PasswordInput: React.FC<Properties> = ({ hasError }) => { | ||
| const [showPassword, setShowPassword] = useState<boolean>(false); |
There was a problem hiding this comment.
| errorMessage || | ||
| UserValidationMessage.INVALID_DATA |
There was a problem hiding this comment.
| errorMessage || | |
| UserValidationMessage.INVALID_DATA | |
| errorMessage ?? | |
| UserValidationMessage.INVALID_DATA |
| user: undefined, | ||
| errorMessage: undefined, |
There was a problem hiding this comment.
replace undefined with null
There was a problem hiding this comment.
I use undefined for errorMessage because on rejected case I assign state.errorMessage = action.error.message which has string | undefined type. And for user I use undefined for consistency.
There was a problem hiding this comment.
Error messages from the backend we will display as Toast notification so there is no need to have this field in store
You will get the error messages that we need from zod
There was a problem hiding this comment.
What about this type of error (when user with provided email does not exist or password is invalid)?
There was a problem hiding this comment.
Skip it for now, we'll also handle it in our middleware
|
Please replace rem with px we will use px throughout the code |
anton-otroshchenko
added
the
MERGE CONFLICTS
o-nedashkivska
force-pushed
the
task/OV-1-add-sign-in-flow
branch
from
64714e3 to
92546b1
Compare
o-nedashkivska
force-pushed
the
task/OV-1-add-sign-in-flow
branch
from
92546b1 to
f554d56
Compare
o-nedashkivska
dismissed stale reviews from nikita-remeslov and anton-otroshchenko
via
fc3f5f3
This PR adds Sign In flow: