OV-2: FEAT: Sign-in flow #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
7 tasks
JKaypa
requested review from
anton-otroshchenko and
sofiia-trokhymchuk
as code owners
anton-otroshchenko
requested changes
Aug 19, 2024
| @@ -9,8 +9,13 @@ class UserRepository implements Repository { | |||
| this.userModel = userModel; | |||
| } | |||
|
|
|||
| public find(): ReturnType<Repository['find']> { | |||
| return Promise.resolve(null); | |||
| public async find(payload: string | number): Promise<UserEntity | null> { | |||
There was a problem hiding this comment.
find method should only find by id.
Please create a specific method if you want to use different fields
for example findByEmail()
anton-otroshchenko
requested changes
Aug 20, 2024
| @@ -1,6 +1,7 @@ | |||
| type Repository<T = unknown> = { | |||
| find(): Promise<T>; | |||
| findAll(): Promise<T[]>; | |||
| findByEmail(email: string): Promise<T>; | |||
There was a problem hiding this comment.
we will have this method only in user repo so there is no need to put this in type here
| @@ -3,6 +3,7 @@ type Service<T = unknown> = { | |||
| findAll(): Promise<{ | |||
| items: T[]; | |||
| }>; | |||
| findByEmail(email: string): Promise<T>; | |||
anton-otroshchenko
previously approved these changes
Aug 20, 2024
nikita-remeslov
requested changes
Aug 20, 2024
| @@ -65,6 +83,17 @@ class AuthController extends BaseController { | |||
| * type: object | |||
| * $ref: '#/components/schemas/User' | |||
| */ | |||
| private async signIn( | |||
There was a problem hiding this comment.
you should add js doc for endpoint
Merged
5 tasks
nikita-remeslov
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add sign-in functionality from the backend. A data transfer object containing user credentials (email, password) is used to compare against existing data