OV-11: Header component #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiy4
requested review from
nikita-remeslov,
anton-otroshchenko and
sofiia-trokhymchuk
as code owners
Closed
3 tasks
anton-otroshchenko
previously approved these changes
Aug 20, 2024
frontend/src/app/app.tsx
Outdated
| @@ -27,6 +31,7 @@ const App: React.FC = () => { | |||
|
|
|||
| return ( | |||
| <> | |||
| <Header /> | |||
There was a problem hiding this comment.
I guess, we should hide header when the path is /sign-in or /sign-up
There was a problem hiding this comment.
Maybe, but I guess this functionality is for another task because I didn't have this in my task.
There was a problem hiding this comment.
Header should be only on internal pages
There was a problem hiding this comment.
because you add header to the root app
o-nedashkivska
previously approved these changes
Aug 20, 2024
nikita-remeslov
requested changes
Aug 20, 2024
sergiy4
dismissed stale reviews from o-nedashkivska and anton-otroshchenko
via
617444e
anton-otroshchenko
requested changes
Aug 20, 2024
frontend/src/app/app.tsx
Outdated
Comment on lines
34
to
38
| {pathname === AppRoute.SIGN_UP || | ||
| pathname === AppRoute.SIGN_IN ? null : ( | ||
| <Header /> | ||
| )} | ||
|
|
There was a problem hiding this comment.
Suggested change
| {pathname === AppRoute.SIGN_UP || | |
| pathname === AppRoute.SIGN_IN ? null : ( | |
| <Header /> | |
| )} | |
| {(pathname !== AppRoute.SIGN_UP && | |
| pathname !== AppRoute.SIGN_IN) && ( | |
| <Header /> | |
| )} | |
o-nedashkivska
previously approved these changes
Aug 20, 2024
stefano-lacorazza
approved these changes
Aug 20, 2024
o-nedashkivska
approved these changes
Aug 20, 2024
anton-otroshchenko
approved these changes
Aug 21, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the Header component.
