OV-3: add sign up flow #30
Conversation
JPjok3r
requested review from
nikita-remeslov,
anton-otroshchenko and
sofiia-trokhymchuk
as code owners
backend/src/migrations/20240820093010_add_name_field_to_users_table.ts
Outdated
Show resolved
Hide resolved
| @@ -5,58 +5,69 @@ class UserEntity implements Entity { | |||
|
|
|||
| private 'email': string; | |||
|
|
|||
| private 'name': string; | |||
There was a problem hiding this comment.
in design looks like we have Full Name
| }; | ||
|
|
||
| const userSignUp = z | ||
| .object<UserSignUpRequestValidationDto>({ | ||
| name: z.string().trim(), |
There was a problem hiding this comment.
We should validate, that name have at least 2 words
JPjok3r
dismissed stale reviews from sergiy4, anton-otroshchenko, and stefano-lacorazza
via
53c0a6a
|
Hi @nikita-remeslov I checked and finished with the observation you made, when you have time you can check it, I based on the front-end code for: |
| @@ -53,6 +53,8 @@ class AuthController extends BaseController { | |||
| * format: email | |||
| * password: | |||
| * type: string | |||
| * name: | |||
There was a problem hiding this comment.
also change it to full name here
There was a problem hiding this comment.
Thanks Anton, it's done.
There was a problem hiding this comment.
looks like not resolved
|
You should change |
|
Hi @nikita-remeslov , @sofiia-trokhymchuk checked that |
Added migration file to create name field in users table
Modified user model and service to save user
Encryption service used
Endpoint /auth/sign-up added, returning object excluding passwords fields
validation checked with the FE code