-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OV-347: Connect Generate Script With Studio Page #381
Merged
sofiia-trokhymchuk
merged 19 commits into
next
from
task/OV-347-connect-generate-script-with-studio
Sep 26, 2024
Merged
OV-347: Connect Generate Script With Studio Page #381
sofiia-trokhymchuk
merged 19 commits into
next
from
task/OV-347-connect-generate-script-with-studio
Sep 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Scene and Script to helper functions
…4-outreachvids into task/OV-347-connect-generate-script-with-studio
…4-outreachvids into task/OV-347-connect-generate-script-with-studio
…4-outreachvids into task/OV-347-connect-generate-script-with-studio
anton-otroshchenko
requested changes
Sep 23, 2024
…oad avatar so always be ready before send to create video
nikita-remeslov
previously approved these changes
Sep 24, 2024
…4-outreachvids into task/OV-347-connect-generate-script-with-studio
…4-outreachvids into task/OV-347-connect-generate-script-with-studio
…4-outreachvids into task/OV-347-connect-generate-script-with-studio
anton-otroshchenko
previously approved these changes
Sep 26, 2024
…4-outreachvids into task/OV-347-connect-generate-script-with-studio
…4-outreachvids into task/OV-347-connect-generate-script-with-studio
sofiia-trokhymchuk
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for this task #347
Important Notes: Properties isVideoScriptsGenerationPending / isVideoScriptsGenerationReady of studio state was made, cause need it a way to know when the addGeneratedVideoScript begin and when it ends that way can trigger the others actions and know when to show and hide the Overlay
Evidence
https://github.com/user-attachments/assets/77360b53-2b83-4f9a-b678-7710ee4115f3