Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OV-424: Error when selecting background before avatar #428

Merged

Conversation

Sanchousina
Copy link
Collaborator

The bug is fixed. User can add background before the avatar to the scene and vice versa

@Sanchousina Sanchousina added BUG Something isn't working FE Fronted feature labels Sep 25, 2024
@Sanchousina Sanchousina added this to the Final DEMO milestone Sep 25, 2024
@Sanchousina Sanchousina self-assigned this Sep 25, 2024
@Sanchousina Sanchousina linked an issue Sep 25, 2024 that may be closed by this pull request
Comment on lines +40 to 47
{scene?.avatar?.url ? (
<RemotionImg
className={styles['avatar']}
src={scene?.avatar?.url ?? ''}
/>
) : (
<></>
)}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we just use && instead without returning the <></>

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, the video player breaks, I tried it

@sofiia-trokhymchuk sofiia-trokhymchuk merged commit 1b58578 into next Sep 26, 2024
2 of 3 checks passed
@sofiia-trokhymchuk sofiia-trokhymchuk deleted the task/OV-424-error-when-select-bg-before-avatar branch September 26, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Something isn't working FE Fronted feature
Projects
Status: To Be Tested
Development

Successfully merging this pull request may close these issues.

BUG: Error when selecting template before avatar in /studio page
3 participants