-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OV-377: Create preview page and flow #429
Changes from 1 commit
b868514
49af338
06e0c10
945fac9
c19a3fa
01bf93f
e7cc793
5e9044d
ba2031e
423cabc
5c7e932
480e38f
556ed1d
907bdaf
c2ebd64
32b55b7
7d1c536
3ae5db1
d932a5a
89fd45d
b012825
b8e9f78
34e1084
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,7 +4,7 @@ import { config } from '~/framework/config/config.js'; | |
const createVideoUrl = (jwtToken: string): string => { | ||
const baseUrl = | ||
config.ENV.APP.ENVIRONMENT === AppEnvironment.PRODUCTION | ||
? 'http://bsa-2024-outreachvids-dev.eu-north-1.elasticbeanstalk.com' | ||
? config.ENV.DEPLOYMENT.URL | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It is better to add something like PUBLIC_URL. And use it as it is without checks There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Im having problems with this one. I changed .env, EnvironmentSchema, and base-config.package adding the new ENV PUBLIC_URL variable but when I try to access it in createVideoUrl I keep getting undefined. |
||
: 'http://localhost:3000'; | ||
|
||
return `${baseUrl}/preview/${jwtToken}`; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.