OV-29: Add Video Items Menu #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…4-outreachvids into tas/OV-29-add-video-items-menu
lfelix3011
requested review from
nikita-remeslov,
anton-otroshchenko and
sofiia-trokhymchuk
as code owners
6 tasks
frontend/src/bundles/video-editor/components/menu-body/menu-body.tsx
Outdated
Show resolved
Hide resolved
anton-otroshchenko
requested changes
Aug 22, 2024
nikita-remeslov
requested changes
Aug 23, 2024
frontend/src/bundles/common/helpers/array-helper/is-empty-array.ts
Outdated
Show resolved
Hide resolved
frontend/src/bundles/common/helpers/is-null-or-undefined/is-null-or-undefined.ts
Outdated
Show resolved
Hide resolved
frontend/src/bundles/common/helpers/string-helpers/is-null-or-undefined.ts
Outdated
Show resolved
Hide resolved
…4-outreachvids into task/OV-29-add-video-items-menu
nikita-remeslov
requested changes
Aug 27, 2024
anton-otroshchenko
requested changes
Aug 27, 2024
frontend/src/bundles/auth/components/common/password-input/password-input.tsx
Outdated
Show resolved
Hide resolved
…4-outreachvids into task/OV-29-add-video-items-menu
…4-outreachvids into task/OV-29-add-video-items-menu
anton-otroshchenko
approved these changes
Aug 29, 2024
Sanchousina
reviewed
Aug 29, 2024
| const [activeContent, setActiveContent] = useState<React.ReactNode | null>( | ||
| null, | ||
| ); | ||
| const [activeTitle, setActiveTitle] = useState<string | React.ReactNode>( |
There was a problem hiding this comment.
If the states are related data, like here title and content, wouldn't it be better to store it as an object?
o-nedashkivska
approved these changes
Aug 30, 2024
nikita-remeslov
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request is for task #29
As suggested in review uses of icons of font-awsome
