OV-50: Integrate-user-card-into-side-bar #56
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JKaypa
requested review from
nikita-remeslov,
anton-otroshchenko and
sofiia-trokhymchuk
as code owners
2 tasks
|
You should change your target branch to task/OV-13-add-side-bar-component |
WilsonBravo
reviewed
Aug 22, 2024
| ); | ||
| }; | ||
|
|
||
| export { HomeIcon, LogOutIcon }; |
There was a problem hiding this comment.
I think it's better to create separate folders for each icon and then export them all in the main icons.tsx file.
icons/
│
├── icons.tsx
│
├── home-icon/
│ └── home-icon.tsx
│
└── log-out-icon/
└── log-out-icon.tsx
There was a problem hiding this comment.
Now instead of custom icons we'll use font awesome icons
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User card integrated into side bar, with collapse styles. User circle component was created