CMake: enable building and installing as a library #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you. It's still a lot of changes, so I'll need to review it. It's queued up. |
|
I would also suggest to add --- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -153,7 +153,7 @@
set(BASISU_LIB_TARGET "basisu_lib")
add_library(${BASISU_LIB_TARGET} ${BASISU_SRC_LIST})
-set_target_properties(${BASISU_LIB_TARGET} PROPERTIES OUTPUT_NAME "basisu")
+set_target_properties(${BASISU_LIB_TARGET} PROPERTIES OUTPUT_NAME "basisu" VERSION "${PROJECT_VERSION}" SOVERSION "${PROJECT_VERSION}")
target_include_directories(${BASISU_LIB_TARGET} PUBLIC
$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/transcoder>
$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/encoder> |
|
Any movement on this PR? It would significantly help with integrating the library in other tools. |
There was a problem hiding this comment.
Redundant, facebook/zstd installs the exported targets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is far less ambitious than #13, but I hope it can be merged more easily as it doesn't reorganize files.
It also generate CMake export files, and a basisu::basisu_lib CMake target, which makes it easy to use basis_universal from other CMake projects
The build can use the ZSTD from the library when available, otherwise fallbacks to the embeded copy.
Tested on Linux (ubuntu 20.04) and Windows (MSVC 2019)