Fix changing number of fields by SeqFilter #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #121 The number of fields in SeqFilter output might differ, the program now extracts the second and the last field. Therefore, it is guaranteed to work with a variable field number.
|
When will we increase version numbers @thackl ? |
|
Good question. When we feel like it I guess ;) |
|
:) I would like to add a test-case for that issue... Therefore, it might be better to wait with the merge. Sorry for already opening it |
|
Sure. I'll wait |
|
I added test to ensure the normal behavior with multiple sequences as well as single sequences. Moreover, I changed the testing system from simply running Will that cause a version number change @thackl ? Your decision :) |
|
Should we add that also to the master branch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #121
The number of fields in SeqFilter output might differ, the program now extracts the second and the last field. Therefore, it is guaranteed to work with a variable field number.