Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance use_vignette_*() #76

Open
wants to merge 6 commits into
base: devel
Choose a base branch
from
Open

Enhance use_vignette_*() #76

wants to merge 6 commits into from

Conversation

mtmorgan
Copy link
Contributor

This pull request enhances use_vignette_*() to provide a version of the vignette suitable for use in a package. It emphasizes overall vignette structure (including package installation instructions, reference to the support site, etc) rather than the features offered by markdown or BiocStyle. Functions gain arguments (e.g., authors = c(person(), person())) for easy production of custom vignettes.

It is partly in response to a Bioconductor community developer forum slack post.

The templating infrastructure under inst/rmarkdown/templates/package_vignette is a little complicated by the desire to provide a templated version for interactive use, and a complete version for RStudio interactive creation. A README.md file in that directory provides update instructions.

- package-specific vignette template
  - emphasize overall structure, rather than BiocStyle features
  - include installation instructions
- add arguments to customize output, e.g., `authors=`
- README.md contains instructions required to keep in sync with RStudio
  interactive selection
- explicit dependency on 'whisker' package was already implicit
- fulfills (partly?) https://community-bioc.slack.com/archives/CLUJWDQF4/p1587422927097500
- requires manual editing on merge to master
- helps distinguish installations from this branch from standard
  installations
@mtmorgan mtmorgan requested a review from aoles April 26, 2020 17:12
@mtmorgan
Copy link
Contributor Author

Hmm, I think I'll revise this a little to augment the original use_vignette_*() functionality, rather than replace it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant