-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added new metrics for regression tasks #364
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,131 @@ | ||
from typing import List, Optional, Union | ||
from fuse.eval.metrics.libs.stat import Stat | ||
from fuse.eval.metrics.metrics_common import MetricDefault | ||
import numpy as np | ||
from sklearn.metrics import mean_absolute_error, mean_squared_error | ||
|
||
|
||
class MetricPearsonCorrelation(MetricDefault): | ||
def __init__( | ||
self, pred: str, target: str, mask: Optional[str] = None, **kwargs: dict | ||
) -> None: | ||
super().__init__( | ||
pred=pred, | ||
target=target, | ||
mask=mask, | ||
metric_func=Stat.pearson_correlation, | ||
**kwargs, | ||
) | ||
|
||
|
||
class MetricSpearmanCorrelation(MetricDefault): | ||
def __init__( | ||
self, pred: str, target: str, mask: Optional[str] = None, **kwargs: dict | ||
) -> None: | ||
super().__init__( | ||
pred=pred, | ||
target=target, | ||
mask=mask, | ||
metric_func=Stat.spearman_correlation, | ||
**kwargs, | ||
) | ||
|
||
|
||
class MetricMAE(MetricDefault): | ||
def __init__( | ||
self, | ||
pred: str, | ||
target: str, | ||
**kwargs: dict, | ||
) -> None: | ||
""" | ||
See MetricDefault for the missing params | ||
:param pred: scalar predictions | ||
:param target: ground truth scalar labels | ||
:param threshold: threshold to apply to both pred and target | ||
:param balanced: optionally to use balanced accuracy (from sklearn) instead of regular accuracy. | ||
""" | ||
super().__init__( | ||
pred=pred, | ||
target=target, | ||
metric_func=self.mae, | ||
**kwargs, | ||
) | ||
|
||
def mae( | ||
self, | ||
pred: Union[List, np.ndarray], | ||
target: Union[List, np.ndarray], | ||
**kwargs: dict, | ||
) -> float: | ||
return mean_absolute_error(y_true=target, y_pred=pred) | ||
|
||
|
||
class MetricMSE(MetricDefault): | ||
def __init__( | ||
self, | ||
pred: str, | ||
target: str, | ||
**kwargs: dict, | ||
) -> None: | ||
""" | ||
Our implementation of standard MSE, current version of scikit dones't support it as a metric. | ||
See MetricDefault for the missing params | ||
:param pred: scalar predictions | ||
:param target: ground truth scalar labels | ||
:param threshold: threshold to apply to both pred and target | ||
:param balanced: optionally to use balanced accuracy (from sklearn) instead of regular accuracy. | ||
""" | ||
super().__init__( | ||
pred=pred, | ||
target=target, | ||
metric_func=self.mse, | ||
**kwargs, | ||
) | ||
|
||
def mse( | ||
self, | ||
pred: Union[List, np.ndarray], | ||
target: Union[List, np.ndarray], | ||
**kwargs: dict, | ||
) -> float: | ||
return mean_squared_error(y_true=target, y_pred=pred) | ||
|
||
|
||
class MetricRMSE(MetricDefault): | ||
def __init__( | ||
self, | ||
pred: str, | ||
target: str, | ||
**kwargs: dict, | ||
) -> None: | ||
""" | ||
See MetricDefault for the missing params | ||
:param pred: scalar predictions | ||
:param target: ground truth scalar labels | ||
:param threshold: threshold to apply to both pred and target | ||
:param balanced: optionally to use balanced accuracy (from sklearn) instead of regular accuracy. | ||
""" | ||
super().__init__( | ||
pred=pred, | ||
target=target, | ||
metric_func=self.mse, | ||
**kwargs, | ||
) | ||
|
||
def mse( | ||
self, | ||
pred: Union[List, np.ndarray], | ||
target: Union[List, np.ndarray], | ||
**kwargs: dict, | ||
) -> float: | ||
|
||
pred = np.array(pred).flatten() | ||
target = np.array(target).flatten() | ||
|
||
assert len(pred) == len( | ||
target | ||
), f"Expected pred and target to have the dimensions but found: {len(pred)} elements in pred and {len(target)} in target" | ||
|
||
squared_diff = (pred - target) ** 2 | ||
return squared_diff.mean() |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we expose nan_policy to be an argument in metric class?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it made sense to me to make this visibility to understand where nans might come from but i don't mind removing