Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui-ux): redirect of dxchf #1866

Merged
merged 2 commits into from
Sep 8, 2023
Merged

Conversation

pierregee
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) does this PR fixes?:

Fixes #

Sample Links & Screenshots:

Link:

Desktop Screenshot
Mobile Screenshot

Additional comments?:

Developer Checklist:

  • Read your code changes at least once
  • Tested on multiple web browsers
  • Tested responsiveness (e.g, iPhone, iPad, Desktop)
  • No console errors
  • Unit tests*
  • Added e2e tests*

@netlify
Copy link

netlify bot commented Sep 7, 2023

Deploy Preview for defi-scan ready!

Name Link
🔨 Latest commit 8985dd5
🔍 Latest deploy log https://app.netlify.com/sites/defi-scan/deploys/64fa7abfde863200083621d6
😎 Deploy Preview https://deploy-preview-1866--defi-scan.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 49 (🔴 down 4 from production)
Accessibility: 75 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@pierregee pierregee marked this pull request as ready for review September 7, 2023 15:03
@pierregee pierregee enabled auto-merge (squash) September 7, 2023 15:03
@pierregee pierregee disabled auto-merge September 7, 2023 15:04
@kyleleow
Copy link
Contributor

kyleleow commented Sep 8, 2023

Need to fix on mobile too.

When we have the time, we should refactor the logic to automate this whenever a poolpair tokenA has a counterpart tokenB of DFI and DUSD.

@pierregee
Copy link
Contributor Author

When we have the time, we should refactor the logic to automate this whenever a poolpair tokenA has a counterpart tokenB of DFI and DUSD.
Agree - whenever there's more than one pair for tokenA

@pierregee pierregee merged commit 1df73f1 into main Sep 8, 2023
14 checks passed
@pierregee pierregee deleted the pierregee/fix-redirect-of-dxchf branch September 8, 2023 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants