add timeout 30 to behat chrome_headless configuration

BitBagCommerce · Jan 23, 2023 · e7cfa37 · e7cfa37
1 parent 5c5373e
commit e7cfa37
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 4 deletions.
diff --git a/UPGRADE.md b/UPGRADE.md
@@ -1,4 +1,4 @@
-# UPGRADE FROM `v1.2.0` TO `v1.2.1`
+# UPGRADE FROM `v1.2.0` TO `v2.0`
 
 New fields were added to BitBag\SyliusBonusPointsPlugin\Entity\BonusPointsInterface:
 
@@ -8,7 +8,8 @@ New fields were added to BitBag\SyliusBonusPointsPlugin\Entity\BonusPointsInterf
 
 > New class `BitBag\SyliusBonusPointsPlugin\Creator\BonusPointsCreator` were added which is responsible to create new BonusPoints entity based on provided data's.
 
-------------------------------
+
+> [BC Break] - The new calculation of points breaks compatibility with existing data records in the db
 
 ### What has changed?
 

diff --git a/behat.yml.dist b/behat.yml.dist
@@ -13,7 +13,7 @@ default:
 
         Behat\MinkExtension:
             files_path: "%paths.base%/vendor/sylius/sylius/src/Sylius/Behat/Resources/fixtures/"
-            base_url: "https://127.0.0.1:8000/"
+            base_url: "https://127.0.0.1:8080/"
             default_session: symfony
             javascript_session: chrome_headless
             sessions:

diff --git a/src/EventListener/OrderBonusPointsListener.php b/src/EventListener/OrderBonusPointsListener.php
@@ -72,6 +72,10 @@ public function assignBonusPoints(ResourceControllerEvent $event): void
 
             $leftPointsFromPool = $availableBonusPoint->getLeftPointsFromAvailablePool();
 
+            if (0 >= $leftPointsFromPool) {
+                continue;
+            }
+
             if ($points >= $leftPointsFromPool) {
                 $this->bonusPointsCreator->createWithData($customerBonusPoints, $order, $leftPointsFromPool, $availableBonusPoint);
 

diff --git a/tests/Application/.env b/tests/Application/.env
@@ -3,7 +3,7 @@
 # https://symfony.com/doc/current/best_practices/configuration.html#infrastructure-related-configuration
 
 ###> symfony/framework-bundle ###
-APP_ENV=test
+APP_ENV=dev
 APP_DEBUG=1
 APP_SECRET=EDITME
 ###< symfony/framework-bundle ###