New Bootstrap-UI #354

tamaskan · 2017-05-24T01:29:16Z

Updated JQuery
Included Standard Roboto-Font
Custom Date-Format via http://momentjs.com/
Coin-Icon-Font via https://labs.allienworks.net/icons/cryptocoins/
Added Total Account-Value and Value per Coin
Different collapsible Sections and Filters
Progressbars and visual Min-Coin-Warning
Increased max. Update-Interval to 3600

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[N/A] I have read CONTRIBUTING.md
[N/A] I fully understand Github Flow.
My code adheres to the code style of this project.
[N/A] I have updated the documentation in /docs if I have changed the config, arguments, logic in how the bot works, or anything that understandably needs a documentation change.
[N/A] I have updated the config file accordingly if my change requires a new configuration setting or changes an existing one.
[N/A] I have tested the bot with no issues for 24 continuous hours. If issues were experienced, they have been patched and tested again.

Updates JQuery Roboto-Font Custom Date-Format via moment.js Coin-Icon-Font via https://labs.allienworks.net/icons/cryptocoins/ Total Account-Value and Value per Coin Different collapsible Sections and Filters Progressbars and visual Min-Coin-Warning Increased max. Update-Interval

rnevet · 2017-05-24T09:26:13Z

General comment, use spaces (not tabs), keep things correctly aligned.

laxdog · 2017-05-25T06:43:15Z

Do we need all the binary files? It's generaly a bad idea to commit binaries to git w/o annex or something similar.

tamaskan · 2017-05-25T19:20:31Z

I haven't found a hosted version of the cryptocoin-font, but it could be reduced to a single .woff2-file

Reduced the CryptoCoin-Font to a single .woff2-File Show the amount of earned Coins since first UI-Start (Stored in localstorage)

rnevet · 2017-05-25T20:05:03Z

'Show the amount of earned Coins since first UI-Start (Stored in
localstorage)'

Not needed, we are going to have complete lending history in this branch:
#349

Please correct tabs as it's really hard to review the code this way.

rnevet · 2017-05-25T21:13:52Z

While I find displaying the opened loans interesting, displaying the cancel loan events is useless as this happens on every bot cycle and doesn't actually bring any information.

rnevet · 2017-05-25T21:14:50Z

rnevet · 2017-05-25T21:17:51Z

The filtering buttons are ignored when a reload happens. :)

rnevet · 2017-05-25T21:43:55Z

I like the overall design, however I think many of the features should be discussed.

In general I would prefer to have first design change and then separate PRs for features... this will also make it easier to review and approve.

tamaskan · 2017-05-25T22:18:51Z

The creators of this bot are free to use only the non-controversial parts and open issues for discussions :-)

Evanito · 2017-05-26T03:24:21Z

www/lendingbot.js

+    var totalvalue = 0;
+
+//Min Coins based on https://github.com/BitBotFactory/poloniexlendingbot/issues/347
+    var items = [['BTC','BTS','CLAM','DASH','DOGE','ETH','FCT','LTC','MAID','STR','XMR','XRP'],[0.00019124,10,10,0,100,0,100,0,10,100,0,100]];


Bitcoin min is actually 0.01, in the issue he was demonstrating the different values of the minimums.

Is there a list of these minimums ?

kingo55 · 2017-05-28T08:43:41Z

The design changes look really nice!

Hiding a bunch of stuff under accordions makes this design less practical though. I like to be able to view all the stats upon a glance. If I have to tap to open accordions, it takes time and effort. Arguably not much, but enough that it makes the old design more useful at this stage.

It gets really annoying when the bot refreshes the page and you lose all the accordion states! :(

tamaskan · 2017-05-28T20:07:12Z

I can change that behavior, thanks for the feedback :-)

Coindetail-Accordions should now stay open during refresh

Needs testing(notifications,logfilter,mincoin), Todo: settings

rnevet · 2017-06-26T08:48:53Z

btw, I made a JSFiddle for prettyFloat
https://jsfiddle.net/mut72zcp/

rnevet · 2017-08-01T23:41:31Z

@tamaskan how about making this an alternate theme based on:
86c3521
?

mchl18 · 2017-08-01T23:44:31Z

some friends and i will work on an alternative frontend soon, but probably on my fork. It really needs an overhaul. I wanna try if vue.js could work and maybe replace bootstrap

rnevet · 2017-08-01T23:45:52Z

@mchl18 have you seen the option to create alternate themes?

tamaskan · 2017-08-01T23:46:01Z

@rnevet sure, that is not a problem.
@mchl18 awesome :-)

mchl18 · 2017-08-01T23:46:29Z

also wanna try and write a config interface...wip

mchl18 · 2017-08-01T23:47:09Z

@rnevet no i have not. I just fiddled with some css overlay but i think i want a complete overhaul

tamaskan · 2017-08-01T23:48:32Z

thought about a configuration-interface, but the main problem is to keep it up to date

mchl18 · 2017-08-01T23:51:00Z

i have some ideas and will try it on my fork

tamaskan · 2017-08-01T23:52:33Z

great :-) do you need help ?

mchl18 · 2017-08-01T23:54:14Z

I havent had time to set it up, wanna meet with some friends to discuss, if I run into questions i will let you know

mchl18 · 2017-08-01T23:56:27Z

vue.js seems tempting but idk if it can handle the whole parsing and all, havent used it before and really wanna try it. also i wanted to create tiles for the currencies instead of tables to make it more customisable and responsive. also bulma could be a nice alternative to bootstrap since I like flexbox.
But i will make a new issue and PR for this. Have to work full time right now, we'll see if that works out. I am a frontend guy by heart

tamaskan · 2017-08-02T00:02:16Z

never worked with that, but it should be able to handle that.

mchl18 · 2017-08-02T00:03:44Z

yeah it looks really slim and easy to set up, much better than angular and simpler than react, but also only js at its core

utdrmac · 2017-08-27T16:17:59Z

@tamaskan What's the status on this? There are some other PRs that want to make UI changes too but this is holding that up and will make the merge of this PR harder. Are you pausing this effort for the moment?

tamaskan · 2017-08-27T19:52:10Z

yes, i am still working on this. the bot supports multiple page-templates, so i see no reason why another developer can't create a PR with his Idea.

rnevet · 2017-08-27T21:21:34Z

@utdrmac as @tamaskan mentioned a recent change to the bot was allowing multiple html templates (IMO might be harder to maintain but it is in).
86c3521

If this is regarding adding the graphs view, I would be happy to have it in the current template.

Works with emilam@8ac7657

gincarbone · 2017-09-16T05:36:56Z

great job

bkuhl · 2018-01-07T15:33:43Z

Seems like a while since this has had a contribution. Is this still a work in progress? Can a screenshot be provided?

bkuhl · 2018-04-25T00:47:49Z

Still no updates here.... hrmmmm... what do we do with this PR?

utdrmac · 2018-07-06T16:05:10Z

Is this PR dead?

SPIRY-RO · 2018-10-29T23:32:50Z

I do think it deserves a neat UI. And the initial PR had a very strong idea in that direction.

tamaskan · 2018-10-29T23:46:07Z

i switched to coinlend.org, but everyone is free to use the code and create something beautiful

tamaskan mentioned this pull request May 24, 2017

Webpage UI Discussion #81

Open

Reduced Font-Files and show earned Coins

46e9de4

Reduced the CryptoCoin-Font to a single .woff2-File Show the amount of earned Coins since first UI-Start (Stored in localstorage)

Tabs->Spaces, Removed Closed-Panel, Filter-Fix, Removed Earnings

88f9086

Evanito reviewed May 26, 2017

View reviewed changes

Evanito added Enhancement Queued Testing Phase labels May 26, 2017

masterxa added 11 commits May 29, 2017 00:08

Changed Accordion-Behavior

01ca9a5

Coindetail-Accordions should now stay open during refresh

Added missing JS

a913090

Experimental Bootstrap-Design WIP

a7c2121

Fixes

23f47f0

Changes

90eb83c

Needs testing(notifications,logfilter,mincoin), Todo: settings

earnings-merge-modifications

b6016c0

Fixes, Table Filter, Notifications

142d7fe

Merge remote-tracking branch 'refs/remotes/origin/experimental'

693a57e

Increased Regex-Length for longer Rates

c16693d

Add Loader

0c97308

Grid -> Earnings 24h/Total

dc6f7a2

Evanito requested a review from rnevet July 26, 2017 01:19

Added Forecast-Graphs to Grid-View

9ceb5d0

masterxa added 3 commits September 15, 2017 20:35

Merge remote-tracking branch 'refs/remotes/BitBotFactory/master'

4263b6e

Table-Template - Work in Progress

6ff9574

Works with emilam@8ac7657

Tab to Space

2a95366

BitBotFactory deleted a comment from gincarbone Feb 7, 2018

tamaskan closed this by deleting the head repository Jun 6, 2023

New Bootstrap-UI #354

New Bootstrap-UI #354

Conversation

tamaskan commented May 24, 2017

Types of changes

Checklist:

rnevet commented May 24, 2017 • edited Loading

laxdog commented May 25, 2017

tamaskan commented May 25, 2017

rnevet commented May 25, 2017

rnevet commented May 25, 2017

rnevet commented May 25, 2017

rnevet commented May 25, 2017

rnevet commented May 25, 2017

tamaskan commented May 25, 2017

Evanito May 26, 2017

Choose a reason for hiding this comment

tamaskan May 26, 2017

Choose a reason for hiding this comment

kingo55 commented May 28, 2017

tamaskan commented May 28, 2017

rnevet commented Jun 26, 2017

rnevet commented Aug 1, 2017

mchl18 commented Aug 1, 2017 • edited Loading

rnevet commented Aug 1, 2017

tamaskan commented Aug 1, 2017

mchl18 commented Aug 1, 2017

mchl18 commented Aug 1, 2017 • edited Loading

tamaskan commented Aug 1, 2017

mchl18 commented Aug 1, 2017

tamaskan commented Aug 1, 2017

mchl18 commented Aug 1, 2017

mchl18 commented Aug 1, 2017 • edited Loading

tamaskan commented Aug 2, 2017

mchl18 commented Aug 2, 2017

utdrmac commented Aug 27, 2017

tamaskan commented Aug 27, 2017

rnevet commented Aug 27, 2017 • edited Loading

gincarbone commented Sep 16, 2017

bkuhl commented Jan 7, 2018

bkuhl commented Apr 25, 2018

utdrmac commented Jul 6, 2018

SPIRY-RO commented Oct 29, 2018

tamaskan commented Oct 29, 2018

rnevet commented May 24, 2017 •

edited

Loading

mchl18 commented Aug 1, 2017 •

edited

Loading

mchl18 commented Aug 1, 2017 •

edited

Loading

mchl18 commented Aug 1, 2017 •

edited

Loading

rnevet commented Aug 27, 2017 •

edited

Loading