frontend: lazy-load languages #2993
Conversation
cstenglein
force-pushed
the
lazy-load-languages
branch
from
6221394 to
58af16b
Compare
|
Very nice. This cuts the size of the main production JavaScript bundle by half (tested with Somehow it doesn't initialize the language from the config correctly, but in the settings shows the correct lang. 
|
|
buildweb with master 
buildweb with this branch 
|
|
webdev is not good to test, in this PR I added looks like this change reduced JS Heap and scripting time current with lazy-load branch |
cstenglein
force-pushed
the
lazy-load-languages
branch
from
58af16b to
8ac388b
Compare
|
Fixed the loading of the language, but not that happy with the implementation with the changing boolean. |
cstenglein
force-pushed
the
lazy-load-languages
branch
from
68e8970 to
94f9b63
Compare
|
Fixed the test and squashed my commits. Should work now. |
|
Thank you so much @cstenglein ! One thing please change the prefix in the commit message from |
cstenglein
force-pushed
the
lazy-load-languages
branch
from
94f9b63 to
91d7407
Compare
| // This is ok since we're just checking for a truthy value in the language detector. | ||
| return getNativeLocale().then((nativeLocale) => { | ||
| // load the default language first | ||
| loadLanguage(defaultLang); |
There was a problem hiding this comment.
I found a small bug in the Qt app:
When the userLanguage in config.json is an empty string (or not defined) the Qt BBApp will always start with English instead of using the native language.
We purposely store an empty string in case the user changes the language to be the same as the system.
How to test:
- change system to something else than English, i.e. German
- change userLanguage to empty string in
~/Library/Application\ Support/bitbox/config.json - open the Qt app, English loads, but expected is that the BBapp loads in German
I can't reproduce this well in webdev as native-locale gives me an empty string on webdev so it always goes to En for me in webdev.
There was a problem hiding this comment.
I played a bit around and the 2nd commit in #3053 fixes the issue for me. Could you test with this and if it works for you squash it into your commit?
There was a problem hiding this comment.
Your version actually partly tries to load to German (with de system and userlang empty string) but the UI is still in English:
|
merged with #3053 |
fixes #1547
Before
After
Shouldn't have that much impact though since the languages are loaded locally.