frontend: update UI of add account dropdown to use react-select #3043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shonsirsha
force-pushed
the
frontend-addaccount-dropdown-restyle
branch
from
f00344c to
b1edc71
Compare
thisconnect
requested changes
Nov 12, 2024
| @@ -0,0 +1,91 @@ | |||
| .dropdown { | |||
| appearance: none; | |||
| background-image: url("data:image/svg+xml,%3Csvg xmlns='http://www.w3.org/2000/svg' width='24' height='24' fill='none' stroke='currentColor' stroke-linecap='round' stroke-linejoin='round' stroke-width='2' aria-labelledby='chevron down' color='%23777'%3E%3Cdefs/%3E%3Cpolyline points='6 10 12 16 18 10'/%3E%3C/svg%3E%0A"); | |||
There was a problem hiding this comment.
We use this inline svg in 4 places (coin-dropdown.tsx, countryselect.tsx, activecurrencies.tsx and singledropdown.tsx), each seem to define their own DropdownIndicator component. It looks you could re-use some components. WDYT?
There was a problem hiding this comment.
Will make a new refactoring PR after this. Then use that component here and in several places.
frontends/web/src/routes/account/add/components/coin-dropdown.tsx
Outdated
Show resolved
Hide resolved
|
Thanks for the review, PTAL @thisconnect |
shonsirsha
force-pushed
the
frontend-addaccount-dropdown-restyle
branch
from
b1edc71 to
502ec01
Compare
thisconnect
requested changes
Nov 12, 2024
frontends/web/src/routes/account/add/components/coin-dropdown.tsx
Outdated
Show resolved
Hide resolved
shonsirsha
force-pushed
the
frontend-addaccount-dropdown-restyle
branch
from
502ec01 to
4ec4e31
Compare
|
Oh good catch. Removed now:) thanks. PTAL @thisconnect |
shonsirsha
force-pushed
the
frontend-addaccount-dropdown-restyle
branch
from
4ec4e31 to
9cd2c69
Compare
Identical UI with the select account dropdown in buy & sell page with icon and coin name on the option and selected value.
shonsirsha
force-pushed
the
frontend-addaccount-dropdown-restyle
branch
from
9cd2c69 to
f0b3bb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identical UI with the select account dropdown in buy & sell page, with icon and coin name on the options and selected value.