Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge release branch into master resolved (v4.46.0) #3060

Merged

Conversation

thisconnect
Copy link
Collaborator

No description provided.

Beerosagos and others added 15 commits November 12, 2024 14:48
7c0b2f6 introduced a 300ms wait between the QrScanner creation and its
start to fix a bug on re-renders of the component, but it seems not
to be enough on certain devices, which still show the bug.

It would be nice to change the 300ms fixed wait to a better way to know
when the scanner is ready to be started but we could not find it.

This commit improves the general structure of the component, to limit
race conditions across re-renders and seems to improve the behavior and
fix the bug with the tested devices.
BTC Direct supports buying and selling LTC through their private
trading desk, so the link and info should also be shown to Litecoin
accounts on exchange selection.
Before the chart on account-summary goes into mobile view below
640px causing the total balance and filters to have no spacing to
the edge of the window if the window was between 640px and 678px.

Fixed by increasing the mobile style to be applied until 678px.
Moonpay recently released a new widget update that requires the webview
to access the DOM storage, causing our iframe integration to fail
loading the widget on Android. This fixes the DOM access issue.
54 has already been used for v4.45.0
…release-branch-conflict

Conflicts:
	CHANGELOG.md
@thisconnect thisconnect changed the title Resolve release branch conflict Merge release branch into master resolved Nov 19, 2024
Copy link
Collaborator

@Beerosagos Beerosagos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK with tiny nit

@@ -15,6 +15,7 @@
- Fix authentication view glitch at startup
- Remove "No priority" from fee options
- Display skeleton screens (placeholder) in the account page during data loading to enhance UX
- Fix Moonpay widget loading issues
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I'd move put the Moonpay change before the skeleton things, as it was released before

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to not move it as it is an unordered list 😇

@thisconnect thisconnect merged commit 37ab166 into BitBoxSwiss:master Nov 25, 2024
7 checks passed
@benma benma changed the title Merge release branch into master resolved Merge release branch into master resolved (v4.46.0) Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants