frontend: show the full text of long transaction notes #3070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thisconnect
force-pushed
the
frontend-long-transaction-notes
branch
from
88284a8 to
44cdc3d
Compare
shonsirsha
requested changes
Nov 26, 2024
| @@ -88,6 +89,8 @@ | |||
| font-variant: tabular-nums; | |||
| } | |||
|
|
|||
| .txAmount-send, | |||
| .txAmount-send_to_self {} | |||
There was a problem hiding this comment.
I should have commented 😇
they are dummy, if they don't exist we get class="undefined"
Long transaction notes were only shown on one line and cut off by an ellipsis symbol. Fixed by always showing the full transaction note and break onto multiple lines if necessary. Transactions without notes show as a fallback a comment such as `received to <address>` which should only use one line and is cut off with an ellipsis...
thisconnect
force-pushed
the
frontend-long-transaction-notes
branch
from
44cdc3d to
549efd6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Long transaction notes were only shown on one line and cut off by an ellipsis symbol.
Fixed by always showing the full transaction note and break onto multiple lines if necessary.
Transactions without notes show as a fallback a comment such as
received to <address>which should only use one line and is cut off with an ellipsis...