Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v4.46.1 -> master #3075

Merged
merged 4 commits into from
Nov 26, 2024
Merged

Release v4.46.1 -> master #3075

merged 4 commits into from
Nov 26, 2024

Conversation

benma
Copy link
Contributor

@benma benma commented Nov 26, 2024

No description provided.

The newer ones require Go 1.23 and fail our Docker image build if we
use Go 1.22. We need to downgrade 1.23 to 1.22 b/c of a Go bug
resulting in the Android app crashing on old Android versions.
Android app compiled with 1.23.2 or 1.23.3 crashes on old Android
verisons (verified crash on Android 9 and Android 10).

Until Go is fixed, we downgrade to the prevoius version we used that
works.
@benma benma requested a review from Beerosagos November 26, 2024 13:20
Copy link
Collaborator

@Beerosagos Beerosagos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@benma benma merged commit 63f43e4 into master Nov 26, 2024
25 of 26 checks passed
@benma benma deleted the release-v4.46.1 branch November 26, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants