frontend/android: create new android id for lnalpha #3078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Beerosagos
force-pushed
the
android-ln-id
branch
2 times, most recently
from
82141da to
6aa1dbc
Compare
Beerosagos
force-pushed
the
android-ln-id
branch
from
6aa1dbc to
2b4429a
Compare
NickeZ
requested changes
Dec 3, 2024
There was a problem hiding this comment.
- Some of the logotypes seem to be the old image
- I think we should build both the regular android debug build and the android lightning build. So duplicate the whole android build (we can use "matrix strategy" to avoid code duplication, but don't waste time on it if you don't want to.
- We should change name to "BBApp Lightning". Otherwise you just see "BitBoxApp ...".
Beerosagos
force-pushed
the
android-ln-id
branch
from
2b4429a to
e6ca247
Compare
Now it is possible to compile the app using separated Android app id, which allows the LN app to co-exhists with the debug one. `make android` now compiles both the debug and lightning versions, `make deploy-ln` to install the lightning one through adb.
Beerosagos
force-pushed
the
android-ln-id
branch
from
e6ca247 to
9f460c0
Compare
|
Updated:
Yes, that is on purpose. We need both a round and a square(ish) icon. The one with the lightning in the corner is good for the last one.
Not sure what you meant with the matrix strategy, but I think now it should be good
Done, but I left the "Alpha" too as I think it is an important warning. Ack? PTAL 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now it is possible to compile the app using separated Android app id, which allows the LN app to co-exhists with the debug one.
make android-lnto compile it,make deploy-lnto install through adb.