frontend: create dialog on remember wallet #3085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shonsirsha
commented
Dec 3, 2024
Comment on lines
+18
to
+22
| useEffect(() => { | ||
| if (config && config.frontend) { | ||
| setShouldNotShowDialog(config.frontend.hideEnableRememberWalletDialog); | ||
| } | ||
| }, [config]); |
There was a problem hiding this comment.
We use this pattern (useLoad+getConfig and useEffect+localstate) quite a lot.
Prob makes sense to create a reusable hook for this e.g useConfig(config.frontend.someconfig). It can just return that 'local state', to be used in the component that uses this useConfig hook.
There was a problem hiding this comment.
since we already get the config in app provider what do you think about having the config in the context ?
One thing to consider is we might need to mock the config for tests, but I guess we can mock the config anyway no matter if it is in context or coming from a hook, wdyt?
Show dialog when enabling remember wallet to better inform users about what the feature is. The dialog is an element itself called EnableRememberWalletDialog. This dialog is (also) controlled by a new config variable called hideEnableRememberWalletDialog. Also created DisableRememberWalletDialog component (just a refactor).
shonsirsha
force-pushed
the
frontend-remember-wallet-enable-dialog
branch
from
34ecdb9 to
7789b86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show dialog when enabling remember wallet to better inform users about what the feature is. The dialog is an element itself called EnableRememberWalletDialog.
This dialog is (also) controlled by a new config variable called hideEnableRememberWalletDialog.
Also created DisableRememberWalletDialog component (just a refactor).