Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend send refactor #3089

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

thisconnect
Copy link
Collaborator

replaces #2955

Type `coinUnit` in `IAccount` to use `CoinUnit`.
Copy link
Collaborator

@shonsirsha shonsirsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one nit:typo

@@ -25,28 +25,23 @@ import { TConfirmSendProps } from '@/routes/account/send/components/confirm/type
import { ConfirmingWaitDialog } from '@/routes/account/send/components/confirm/dialogs/confirm-wait-dialog';
import style from './confirm.module.css';

type TConfimrSend = { bb01Paired: boolean | undefined } & TConfirmSendProps;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo Confirm

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch, fixed! thanks

Utilize the `SendWrapper` to get BitBox01 mobile-channel-error and
paired-status. This simplifies the `Send` component and better
distinguishes code for bb01/bb02 stuff.
@thisconnect thisconnect force-pushed the frontend-send-refactor branch from 4c81ac9 to 7aef20d Compare December 4, 2024 13:14
@thisconnect thisconnect merged commit ec61327 into BitBoxSwiss:master Dec 4, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants