frontend: fix chart edgecase to properly update the total amount #3095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On mobile the total changes when the user selects a point on the chart so that they can see exact amount at the time. With scrolling or 2nd finger changing the currency it can happen that the amount does not update, ending up with a wrong amount/unit. Fixed by resetting the tooltip value if the currency changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On mobile the total changes when the user selects a point on the chart so that they can see exact amount at the time.
With scrolling or 2nd finger changing the currency it can happen that the amount does not update, ending up with a wrong amount/unit.
Fixed by resetting the tooltip value if the currency changes.