Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(statics): adding ofctgousd and ofceth:gousd in coins.ts #5384

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

damodarnaik699
Copy link
Contributor

Ticket: USDS-119

@damodarnaik699 damodarnaik699 force-pushed the USDS-119 branch 2 times, most recently from 0c2f7e5 to cbfb038 Compare January 17, 2025 13:09
@damodarnaik699 damodarnaik699 marked this pull request as ready for review January 17, 2025 13:41
@damodarnaik699 damodarnaik699 requested review from a team as code owners January 17, 2025 13:41
@Phani024 Phani024 marked this pull request as draft January 17, 2025 13:44
@@ -13682,6 +13682,7 @@ export const coins = CoinMap.fromCoins([
ofcerc20('d3f81454-874d-44a2-96e9-2fa37b5311b3', 'ofceth:turbo', 'Turbo', 18, UnderlyingAsset['eth:turbo']),
ofcerc20('509e7614-4134-4f4a-b107-cd3b4783a558', 'ofceth:spx', 'SPX6900', 8, UnderlyingAsset['eth:spx']),
ofcerc20('2c863d38-6d3b-438a-983d-79f20aff030a', 'ofceth:kava', 'Kava', 6, UnderlyingAsset['eth:kava']),
ofcerc20('53a414b4-cefa-4a81-936c-9ecbb2da22cc', 'ofceth:gousd', 'GoUSD', 6, UnderlyingAsset['eth:gousd']),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ofcerc20('53a414b4-cefa-4a81-936c-9ecbb2da22cc', 'ofceth:gousd', 'GoUSD', 6, UnderlyingAsset['eth:gousd']),
ofcerc20('53a414b4-cefa-4a81-936c-9ecbb2da22cc', 'ofceth:gousd', 'goUSD', 6, UnderlyingAsset['eth:gousd']),

@damodarnaik699 damodarnaik699 marked this pull request as ready for review January 17, 2025 14:57
@damodarnaik699 damodarnaik699 merged commit 3b15e62 into master Jan 20, 2025
6 checks passed
'ofctgousd',
'Holesky Testnet GoUSD',
6,
UnderlyingAsset.TGOUSD,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be HTETH:GOUSD?

Copy link
Contributor

@Phani024 Phani024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@damodarnaik699 Please don't open the PRs for review when they is not ready.
I moved it to Draft because we did not make a decision on the symbol for the test version of this token, yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants