Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: export substitute path params #749

Merged

Conversation

domoneill18
Copy link
Contributor

@domoneill18 domoneill18 commented Apr 26, 2024

Adds substitutePathParams to superagent-wrapper exports.

Motivation: We are working on integrating with a new partner with which our contact specifies that we need to include the url path we are sending a request to in the data we sign (for a signature header). Currently we have all of our partners apis defined via api-ts specs so I'm looking to be able to pull this logic from superagent-wrapper for that use-case.

@domoneill18 domoneill18 requested a review from a team as a code owner April 26, 2024 17:28
@domoneill18 domoneill18 marked this pull request as draft April 26, 2024 17:30
@domoneill18 domoneill18 marked this pull request as ready for review April 26, 2024 17:45
@ericcrosson-bitgo
Copy link
Contributor

Hi @domoneill18, can you please clue me in to your motivations? This intentionally hasn't been considered a part of this package's public API, so I'm curious what problem you'll be able to solve in exchange for the public visibility.

@domoneill18
Copy link
Contributor Author

Hi @domoneill18, can you please clue me in to your motivations? This intentionally hasn't been considered a part of this package's public API, so I'm curious what problem you'll be able to solve in exchange for the public visibility.

For context on why I am looking to export this function, we are working on integrating with a new partner with which our contact specifies that we need to include the url path we are sending a request to in the data we sign (for a signature header). Currently we have all of our partners apis defined via api-ts specs so I'm looking to be able to pull this logic from superagent-wrapper for that use-case.

@ericcrosson-bitgo
Copy link
Contributor

Thanks for the context @domoneill18 🚀

@ericcrosson-bitgo ericcrosson-bitgo merged commit dfe85e5 into BitGo:master Apr 29, 2024
9 checks passed
Copy link

🎉 This PR is included in version @api-ts/[email protected] 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

Copy link

🎉 This PR is included in version @api-ts/[email protected] 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

Copy link

🎉 This PR is included in version @api-ts/[email protected] 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

Copy link

github-actions bot commented May 2, 2024

🎉 This PR is included in version @api-ts/[email protected] 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

Copy link

github-actions bot commented Aug 5, 2024

🎉 This PR is included in version @api-ts/[email protected] 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants