-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: export substitute path params #749
feat: export substitute path params #749
Conversation
Hi @domoneill18, can you please clue me in to your motivations? This intentionally hasn't been considered a part of this package's public API, so I'm curious what problem you'll be able to solve in exchange for the public visibility. |
For context on why I am looking to export this function, we are working on integrating with a new partner with which our contact specifies that we need to include the url path we are sending a request to in the data we sign (for a signature header). Currently we have all of our partners apis defined via api-ts specs so I'm looking to be able to pull this logic from superagent-wrapper for that use-case. |
Thanks for the context @domoneill18 🚀 |
🎉 This PR is included in version @api-ts/[email protected] 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
🎉 This PR is included in version @api-ts/[email protected] 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
🎉 This PR is included in version @api-ts/[email protected] 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
🎉 This PR is included in version @api-ts/[email protected] 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
🎉 This PR is included in version @api-ts/[email protected] 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
Adds substitutePathParams to superagent-wrapper exports.
Motivation: We are working on integrating with a new partner with which our contact specifies that we need to include the url path we are sending a request to in the data we sign (for a signature header). Currently we have all of our partners apis defined via api-ts specs so I'm looking to be able to pull this logic from superagent-wrapper for that use-case.