Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort HTTP verbs within each path in OpenAPI spec #927

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

bitgopatmcl
Copy link
Contributor

Sort HTTP verbs within each path in the OpenAPI specification.

  • Modify convertRoutesToOpenAPI function in packages/openapi-generator/src/openapi.ts to sort HTTP verbs within each path after sorting the paths.
  • Add a test case in packages/openapi-generator/test/openapi/base.test.ts to verify the sorting of HTTP verbs within each path.

@bitgopatmcl bitgopatmcl force-pushed the bitgopatmcl/sort-http-verbs branch 2 times, most recently from 8a35ec5 to b9d8f09 Compare October 24, 2024 20:23
@bitgopatmcl bitgopatmcl marked this pull request as ready for review October 24, 2024 20:26
@bitgopatmcl bitgopatmcl requested a review from a team as a code owner October 24, 2024 20:26
@bitgopatmcl bitgopatmcl marked this pull request as draft October 24, 2024 21:00
Sort HTTP verbs within each path in the OpenAPI specification.

* Modify `convertRoutesToOpenAPI` function in `packages/openapi-generator/src/openapi.ts` to sort HTTP verbs within each path after sorting the paths.
* Add a test case in `packages/openapi-generator/test/openapi/base.test.ts` to verify the sorting of HTTP verbs within each path.
@bitgopatmcl bitgopatmcl force-pushed the bitgopatmcl/sort-http-verbs branch from b9d8f09 to cf10220 Compare October 24, 2024 21:00
@bitgopatmcl bitgopatmcl marked this pull request as ready for review October 25, 2024 14:09
Copy link
Contributor

@ericcrosson-bitgo ericcrosson-bitgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorts verbs within each path

@ericcrosson-bitgo ericcrosson-bitgo merged commit 5ed6340 into master Oct 25, 2024
6 checks passed
@ericcrosson-bitgo ericcrosson-bitgo deleted the bitgopatmcl/sort-http-verbs branch October 25, 2024 15:45
Copy link

🎉 This PR is included in version @api-ts/[email protected] 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

Copy link

🎉 This PR is included in version @api-ts/[email protected] 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

Copy link

🎉 This PR is included in version @api-ts/[email protected] 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

Copy link

🎉 This PR is included in version @api-ts/[email protected] 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants