-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge pull request #55 from BitGo/CT-698-eos #56
base: CT-698-eos
Are you sure you want to change the base?
Conversation
CT-698 Add EOS signing logic
CT-856 - Bump SDK version to 7.0.0-rc.0
Adds @bitgo/account-lib dependency Adds signing helper for TRON Adds a test for signing a TRON tx
We were differentiating testnet vs mainnet coins based on whether they start with a 't' before. This doesn't work anymore with TRON (symbol trx), so instead we now use statics
[TRON-58] Add KRS Support for TRON
Interview coding challenge - Long Nguyen
This bumps the used ethereumjs-util from 4.5.0 to 6.2.0. The existing dependency bitgo already depended on ethereumjs-util which is why an older version was already included in the dependency tree.
This function was missing a function application at the end, meaning that its return type was function and not string as it should be. This has now been fixed. It took me a bit too long to find this bug so included in this commit is a small change to make the code a bit less compact by declaring the return value from getBackupSigningKey to an appropriately named local variable. Also improves nomenclature in getBackupSigningKey by explictly distinguishing between regular private keys and extended private keys.
Add a check to verify that the XLM master seed is a valid seed for key derivation. Stellar Ecosystem Proposal 5 specifies (through BIP39 and BIP32) that valid seeds are between 128 bit and 512 bit. This fixes a bug when running the tests under latest node version (12.16.1) where the function utils.js/deriveChildKey would accept an invalid seed and derive child keys from this seed. This fix has been tested to work under both node v6 (current production version) and latest version (v12).
Clarifies two ETH test cases and adds/improves documentation to various functions.
This replaces the use of the `sign` function in `ethereumjs-tx` with the `ecsign` function from the `ethereumjs-util` package as requested in We currently chose not to use EIP155 when generating the signatures. To add this, we would need to know the chain ID for the Ethereum chain we are signing the transaction. Activating EIP155 would make the generated signatures replay-resistant on other Ethereum blockchains.
Fix broken unit tests
Add the following support in .drone.yml: 1) Support for both node versions 10 and 6. 2) Support for npm audit. 3) Support for eslint. JIRA: BG-18745
Issues with the configuration of drone caused it to throw an unmarshall error. Moved to jsonnet as it keeps things a little more locked in and easier to do more creative things in the future. Ticket: BG-18745
* SDK bitgo 10.0.0 * bitgo/statics 3.4.2 * bitgo/account-lib 1.0.2 * stellar-hd-wallet 0.0.10 (result of npm audit fix) * mocha 7.1.1 (result of npm audit fix) JIRA: BG-19209
BG-18658 Implement CI pipeline for our KRSv2 project.
Fix Tests and Lint
version, add useFindAndModify spec to findOneAndUpdate query
…t in testutils file
Use new import path Issue: BG-34381
Created by IntelliJ Issue: BG-34381
The updated utxolib uses a different `consensusBranchId` for zcash and thus serializes the transaction differently. Issue: BG-34381
There is no plausible use case where we want to instantiate a bip32 node from just the private key buffer (without chaincode). Issue: BG-34381
HDNode will be deprecated in a future utxolib version Issue: BG-34381
Throwing stuff and seeing what sticks Issue: BG-34381
chore(package): use @bitgo/utxo-lib
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is protestware?This package is a joke, parody, or includes undocumented or hidden behavior unrelated to its primary function. Consider that consuming this package my come along with functionality unrelated to its primary purpose. What is an install script?Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts. Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead. What's wrong with native code?Contains native code which could be a vector to obscure malicious code, and generally decrease the likelihood of reproducible or reliable installs. Ensure that native code bindings are expected. Consumers may consider pure JS and functionally similar alternatives to avoid the challenges and risks associated with native code bindings. What are git dependencies?Contains a dependency which resolves to a remote git URL. Dependencies fetched from git URLs are not immutable can be used to inject untrusted code or reduce the likelihood of a reproducible install. Publish the git dependency to npm or a private package repository and consume it from there. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
Bumps [protobufjs](https://github.com/protobufjs/protobuf.js) from 6.11.2 to 6.11.4. - [Release notes](https://github.com/protobufjs/protobuf.js/releases) - [Changelog](https://github.com/protobufjs/protobuf.js/blob/master/CHANGELOG.md) - [Commits](https://github.com/protobufjs/protobuf.js/commits) --- updated-dependencies: - dependency-name: protobufjs dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
…-6.11.4 Bump protobufjs from 6.11.2 to 6.11.4
Bumps [mongoose](https://github.com/Automattic/mongoose) from 5.13.3 to 5.13.20. - [Release notes](https://github.com/Automattic/mongoose/releases) - [Changelog](https://github.com/Automattic/mongoose/blob/master/CHANGELOG.md) - [Commits](Automattic/mongoose@5.13.3...5.13.20) --- updated-dependencies: - dependency-name: mongoose dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [minimist](https://github.com/minimistjs/minimist) from 1.2.5 to 1.2.8. - [Changelog](https://github.com/minimistjs/minimist/blob/main/CHANGELOG.md) - [Commits](minimistjs/minimist@v1.2.5...v1.2.8) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [webpack](https://github.com/webpack/webpack) from 5.52.0 to 5.90.1. - [Release notes](https://github.com/webpack/webpack/releases) - [Commits](webpack/webpack@v5.52.0...v5.90.1) --- updated-dependencies: - dependency-name: webpack dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
….2.8 Bump minimist from 1.2.5 to 1.2.8
…90.1 Bump webpack from 5.52.0 to 5.90.1
….13.20 Bump mongoose from 5.13.3 to 5.13.20
This PR enable github advanced security workflow Ticket: DO-8117
chore: enable github advanced security workflow
CT-698 Add EOS signing logic
Motivation
Overview Of Changes