Initial CI Workflow #43
Conversation
| push: | ||
| branches: [ "main", "testnet" ] | ||
| pull_request: | ||
| branches: [ "main", "testnet" ] |
There was a problem hiding this comment.
[Recommendation] Having a localnet or devnet stage here would be good. Show it works locally and mess around first. Testnet is a good testing ground for functionally correct and working updates. Having a dedicated devnet environment would be a good idea
There was a problem hiding this comment.
- Good idea, this feels like a better flow for integration tests than going straight to testnet.
- Also agree that a dedicated env is definitely the way to go, spinning it up during the CI workflow would make the test process insanely long.
- If it still ends up being a longer running test, we can update triggers to only run it for specific pre-release tags or something instead of on every push/PR so it doesn't slow down the dev cycle
There was a problem hiding this comment.
What was in this api folder previously?
Is there any code bloat we can clean up?
There was a problem hiding this comment.
the api folder was from the bittensor-subnet-template repo, it's there if we ever want to use it, but since we currently don't we can remove it.
Also removing the generate_synthetic_dataset.py script, this is a quite out of date version and @benliang99 has vastly improved on it in his branch: https://github.com/BitMind-AI/bitmind-subnet/blob/synthetic_image_gen_updates/bitmind/synthetic_image_generation/generate_synthetic_dataset.py
| return Image.fromarray(random_data) | ||
|
|
||
|
|
||
| class MockImageDataset: |
There was a problem hiding this comment.
[Recommendation] Have a mock non-comptabile synapse (something like HealthI) to test the negative case
…age flows in vali fwd
…ace cfg with bt.config
… neuron was already registered in previous test instance
Adding CI with GitHub Actions and pytest