Separate training data #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dylanuys
commented
Oct 2, 2024
dylanuys
commented
- Creating separate constants entry for validator datasets, so training datasets can be changed without changing validator behavior
- Removing old reward function code to clean things up before upcoming reward refactor
benliang99
reviewed
Oct 2, 2024
| @@ -27,6 +27,15 @@ | |||
| ] | |||
| } | |||
|
|
|||
| VALIDATOR_DATASET_META = { | |||
There was a problem hiding this comment.
Question: Should we rename DATASET_META into TRAINING_DATASET_META for clarity? Or something more general, considering we also have the face-specific datasets. @dylanuys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.