This repository has been archived by the owner on Jan 10, 2025. It is now read-only.
LSPS2: Mitigation against prepayment probing. #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Can we close this or is this still a concern? |
|
Dunno if still a concern. shrug |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #44
This is just one of two pull requests for this.
Please wait for the other one as well.#47 is the other one.In this particular pull request, we assume that the conditional probability of an actual payment occurring after a prepayment probe reaches the client is very high, and that any deviation from 100% can be considered an operational overhead of the LSP. This also only applies in "LSP trusts client" model; if the model is "client trusts LSP" then the LSP can defer broadcasting the funding transaction and if the payment does not push through (i.e. prepayment probe occurred but no payment) then the LSP simply does not broadcast the signed funding transaction but instead simply reuses the same inputs for a different, paying service.