Create identity flow #120
Open
Create identity flow #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #120 +/- ##
==========================================
- Coverage 13.59% 12.22% -1.37%
==========================================
Files 104 116 +12
Lines 6769 7638 +869
Branches 228 240 +12
==========================================
+ Hits 920 934 +14
- Misses 5849 6704 +855
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mjkeaton
reviewed
Dec 9, 2024
mjkeaton
reviewed
Dec 9, 2024
mjkeaton
reviewed
Dec 9, 2024
| @@ -34,3 +34,12 @@ export const truncateFileName = (name: string) => { | |||
| ? `${baseName.slice(0, 5)}...${baseName.slice(-3)}${extension}` | |||
| : name; | |||
| }; | |||
|
|
|||
| export const getInitials = (name: string): string => { | |||
There was a problem hiding this comment.
Would be awesome to have some tests for this. (e.g. with "", "a", "a z", "abc bcd cde", etc.)
|
@cryptosalomao Let me know when this is ready for review 🙏 |
mjkeaton
reviewed
Dec 13, 2024
mjkeaton
reviewed
Dec 13, 2024
mjkeaton
reviewed
Dec 13, 2024
mjkeaton
approved these changes
Dec 13, 2024
Co-authored-by: Michael Keaton <[email protected]>
Co-authored-by: Michael Keaton <[email protected]>
Co-authored-by: Michael Keaton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR introduces the new identity creation flow for both personal and company types of identity. More details to be added soon.
Relates to #(issue-number)
📸 Screenshots/Screen record (if applicable)
If your changes include UI updates, please add before and after screenshots/screen records:
Before:
[Attach screenshot/screen record]
After:
[Attach screenshot/screen record]
✅ Checklist
Please ensure the following tasks are completed before requesting a review:
npm run lintor the equivalent linting command.🚀 Changes Made
New Features:
Bug Fixes:
Refactoring:
Other Changes:
💡 How to Test
Please provide clear instructions on how reviewers can test your changes:
🤝 Related Issues
List any related issues, pull requests, or discussions:
🔗 Additional Context (optional)
Add any other context or information that might be useful for reviewers:
[Additional notes or links]
📄 Relevant Documentation (optional)
Provide links to relevant documentation that reviewers may need:
📋 Review Guidelines
Please focus on the following while reviewing: