Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Contacts search #211

Merged
merged 15 commits into from
Dec 20, 2024
Merged

feat: Contacts search #211

merged 15 commits into from
Dec 20, 2024

Conversation

mjkeaton
Copy link
Collaborator

@mjkeaton mjkeaton commented Dec 19, 2024

πŸ“ Description

Relates to #187


πŸ“Έ Screenshots/Screen record (if applicable)


βœ… Checklist

Please ensure the following tasks are completed before requesting a review:

  • My code adheres to the style guidelines of this project.
  • I have run npm run lint or the equivalent linting command.
  • I have added or updated tests (if applicable).
  • My changes have been tested thoroughly in different browsers/resolutions (if applicable).
  • I have updated the documentation (if applicable).
  • I have checked that there are no console errors or warnings.
  • I have verified that the application builds without errors.
  • I have tested responsiveness for mobile and desktop views (if applicable).

πŸš€ Changes Made

  • New Features:
    • Search functionality on contacts page

πŸ’‘ How to Test

Please provide clear instructions on how reviewers can test your changes:

  1. Run with npm run dev
  2. Navigate to http://localhost:5173/contacts
  3. And/or navigate to http://localhost:5173/contacts?scenario=empty

🀝 Related Issues

List any related issues, pull requests, or discussions:

πŸ“„ Relevant Documentation (optional)

Provide links to relevant documentation that reviewers may need:

https://tanstack.com/query/v4/docs/framework/react/overview
https://mswjs.io/docs/best-practices/dynamic-mock-scenarios

Copy link

vercel bot commented Dec 19, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated (UTC)
e-bill-frontend βœ… Ready (Inspect) Visit Preview Dec 20, 2024 0:00am

@mjkeaton mjkeaton self-assigned this Dec 19, 2024
@mjkeaton mjkeaton added the enhancement Enhancement of existing code label Dec 19, 2024
@mjkeaton mjkeaton force-pushed the mjk/187-contacts-search branch from 7e6b512 to 6939816 Compare December 19, 2024 13:21
@mjkeaton mjkeaton marked this pull request as ready for review December 19, 2024 13:32
Copy link
Collaborator

@cryptosalomao cryptosalomao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mjkeaton mjkeaton merged commit 2473528 into main Dec 20, 2024
4 of 5 checks passed
@mjkeaton mjkeaton deleted the mjk/187-contacts-search branch December 20, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants