Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase revamp into main #26

Merged
merged 36 commits into from
Nov 6, 2024
Merged

Rebase revamp into main #26

merged 36 commits into from
Nov 6, 2024

Conversation

cryptosalomao
Copy link
Collaborator

This PR addresses the breaking changes between the current WIP branch revamp and the main branch

@cryptosalomao cryptosalomao self-assigned this Nov 4, 2024
Copy link

vercel bot commented Nov 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
e-bill-frontend ✅ Ready (Inspect) Visit Preview Nov 6, 2024 1:16pm

@mtbitcr
Copy link
Contributor

mtbitcr commented Nov 5, 2024

Screenshot 2024-11-05 at 09 42 01
lets try to remove this "-- --coverage" because our test fails. When test will be green - we can merge

Copy link
Contributor

@mtbitcr mtbitcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix pipeline

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 8.73786% with 1504 lines in your changes missing coverage. Please review.

Project coverage is 8.73%. Comparing base (81e4799) to head (55f0bc6).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/pages/onboarding/CreateIdentity.tsx 0.00% 293 Missing ⚠️
src/pages/Home.tsx 0.00% 226 Missing ⚠️
src/pages/RecoverWithSeedPhrase.tsx 0.00% 115 Missing ⚠️
src/components/ui/select.tsx 0.00% 110 Missing ⚠️
src/components/ui/form.tsx 0.00% 101 Missing ⚠️
tailwind.config.js 0.00% 93 Missing ⚠️
src/pages/onboarding/ProfileInfo.tsx 0.00% 66 Missing ⚠️
src/hooks/useEnvironmentAwareAction.ts 0.00% 65 Missing ⚠️
src/pages/Login.tsx 0.00% 65 Missing ⚠️
src/main.tsx 0.00% 58 Missing ⚠️
... and 13 more
Additional details and impacted files
@@           Coverage Diff            @@
##            main     #26      +/-   ##
========================================
+ Coverage   0.00%   8.73%   +8.73%     
========================================
  Files         44      27      -17     
  Lines       3504    1648    -1856     
  Branches       1      44      +43     
========================================
+ Hits           0     144     +144     
+ Misses      3504    1504    -2000     
Flag Coverage Δ
unittests 8.73% <8.73%> (+8.73%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtbitcr mtbitcr merged commit 1cb592c into main Nov 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants