Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure i18n folders for crowdin #85

Closed
wants to merge 5 commits into from
Closed

Conversation

mtbitcr
Copy link
Contributor

@mtbitcr mtbitcr commented Nov 21, 2024

No description provided.

@mtbitcr mtbitcr self-assigned this Nov 21, 2024
Copy link

vercel bot commented Nov 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
e-bill-frontend ✅ Ready (Inspect) Visit Preview Nov 25, 2024 8:34am

@mtbitcr mtbitcr changed the title Restructure i18n folders for crowdin. Restructure i18n folders for crowdin Nov 21, 2024
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.

Project coverage is 5.59%. Comparing base (3a4331e) to head (63aaeb2).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
src/context/LanguageContext.tsx 0.00% 20 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main     #85      +/-   ##
========================================
- Coverage   5.61%   5.59%   -0.03%     
========================================
  Files         51      51              
  Lines       3597    3613      +16     
  Branches      33      33              
========================================
  Hits         202     202              
- Misses      3395    3411      +16     
Flag Coverage Δ
unittests 5.59% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* Delete en.json.

* New translations login.json (Turkish)

* New translations login.json (Spanish, Argentina)

* New translations unlock.json (Turkish)

* New translations unlock.json (Spanish, Argentina)

* chore: add locales importer helper

---------

Co-authored-by: Guilherme Salomão <[email protected]>
@@ -10,7 +10,7 @@
"test": "vitest",
"preview": "vite preview",
"extract": "formatjs extract 'src/**/*.{ts,tsx}' --ignore='**/*.d.ts' --out-file './extracted/en.json' --id-interpolation-pattern '[sha512:contenthash:base64:6]'",
"extract-simple": "formatjs extract 'src/**/*.{ts,tsx}' --ignore='**/*.d.ts' --out-file './src/i18n/en.json' --id-interpolation-pattern '[sha512:contenthash:base64:6]' --format simple",
"extract-simple": "formatjs extract 'src/**/*.{ts,tsx}' --ignore='**/*.d.ts' --out-file './src/i18n/en.json' --id-interpolation-pattern '[sha512:contenthash:base64:6]' --format simple",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"extract-simple": "formatjs extract 'src/**/*.{ts,tsx}' --ignore='**/*.d.ts' --out-file './src/i18n/en.json' --id-interpolation-pattern '[sha512:contenthash:base64:6]' --format simple",
"extract-simple": "formatjs extract 'src/**/*.{ts,tsx}' --ignore='**/*.d.ts' --out-file './src/i18n/en.json' --id-interpolation-pattern '[sha512:contenthash:base64:6]' --format simple",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did this extra tab for @cryptosalomao. Because here I indicate that we must change this line because of my changes, but I'm not sure how

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cryptosalomao please check it. Or @mjkeaton if you know how to do it

Copy link
Collaborator

@mjkeaton mjkeaton Nov 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, okay. That was not clear to me. Thanks for clarifying! 🙏
I was just wondering the same, actually!

Can we describe the steps necessary from a new language key to its translation being integrated?
Do we use Crowdin Github Action? I am not familiar with Crowdin and have not used it yet.

Copy link
Contributor Author

@mtbitcr mtbitcr Nov 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not familiar with Crowdin and have not used it yet.

Me too ;0. Playing with it now

https://www.youtube.com/watch?v=5b7BMuCoKGg

@mjkeaton
Copy link
Collaborator

Superseded by #106.

@mjkeaton mjkeaton closed this Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants