-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure i18n folders for crowdin #85
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #85 +/- ##
========================================
- Coverage 5.61% 5.59% -0.03%
========================================
Files 51 51
Lines 3597 3613 +16
Branches 33 33
========================================
Hits 202 202
- Misses 3395 3411 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
* Delete en.json. * New translations login.json (Turkish) * New translations login.json (Spanish, Argentina) * New translations unlock.json (Turkish) * New translations unlock.json (Spanish, Argentina) * chore: add locales importer helper --------- Co-authored-by: Guilherme Salomão <[email protected]>
@@ -10,7 +10,7 @@ | |||
"test": "vitest", | |||
"preview": "vite preview", | |||
"extract": "formatjs extract 'src/**/*.{ts,tsx}' --ignore='**/*.d.ts' --out-file './extracted/en.json' --id-interpolation-pattern '[sha512:contenthash:base64:6]'", | |||
"extract-simple": "formatjs extract 'src/**/*.{ts,tsx}' --ignore='**/*.d.ts' --out-file './src/i18n/en.json' --id-interpolation-pattern '[sha512:contenthash:base64:6]' --format simple", | |||
"extract-simple": "formatjs extract 'src/**/*.{ts,tsx}' --ignore='**/*.d.ts' --out-file './src/i18n/en.json' --id-interpolation-pattern '[sha512:contenthash:base64:6]' --format simple", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"extract-simple": "formatjs extract 'src/**/*.{ts,tsx}' --ignore='**/*.d.ts' --out-file './src/i18n/en.json' --id-interpolation-pattern '[sha512:contenthash:base64:6]' --format simple", | |
"extract-simple": "formatjs extract 'src/**/*.{ts,tsx}' --ignore='**/*.d.ts' --out-file './src/i18n/en.json' --id-interpolation-pattern '[sha512:contenthash:base64:6]' --format simple", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did this extra tab for @cryptosalomao. Because here I indicate that we must change this line because of my changes, but I'm not sure how
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cryptosalomao please check it. Or @mjkeaton if you know how to do it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, okay. That was not clear to me. Thanks for clarifying! 🙏
I was just wondering the same, actually!
Can we describe the steps necessary from a new language key to its translation being integrated?
Do we use Crowdin Github Action? I am not familiar with Crowdin and have not used it yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not familiar with Crowdin and have not used it yet.
Me too ;0. Playing with it now
Superseded by #106. |
No description provided.