85: fix logs #190
Merged
85: fix logs #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #190 +/- ##
=========================================
- Coverage 4.19% 4.09% -0.10%
=========================================
Files 29 29
Lines 7175 6832 -343
=========================================
- Hits 301 280 -21
+ Misses 6874 6552 -322 ☔ View full report in Codecov by Sentry. |
mtbitcr
approved these changes
Oct 28, 2024
zupzup
force-pushed
the
85-fix-all-logs-make-it-better
branch
from
08fa92a to
3cbf985
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft until #188 is merged
This fixes #85.
All instances of
printlnwere replaced with variants of log::info!/warn!/error! and I updated the docs, so the app is ran withRUST_LOGset to the desired log level.I removed the logs from the web handlers, since their being called is logged anyway using rocket, if RUST_LOG is set to
info.I didn't add any additional logging for now, since dht is well instrumented and the web handlers are as well via rocket. Once we fully implement Result-based error handling, we'll add logs for error-cases anyway.
For critical parts, we can also add trace, or debug logs, as soon as we run into issues.