Nostr relay #282
Nostr relay #282
Conversation
| } | ||
|
|
||
| let local_public_key = identity_store.get_key_pair().await?.get_libp2p_keys()?; | ||
| let keys = identity_store.get_or_create_key_pair().await?; |
There was a problem hiding this comment.
what key is it? SecP or Rsa? Maybe better name for this varuable
There was a problem hiding this comment.
secP in this case - in new code, I used key, private_key and public_key for our "main" keys (secp) and if it's rsa, I tried to call them rsa_keys, rsa_public_key etc. as a convention.
This would be consistent with that, but we'd have to change it once across the whole codebase to be really clean.
| } | ||
|
|
||
| let local_public_key = identity_store.get_key_pair().await?.get_libp2p_keys()?; | ||
| let keys = identity_store.get_or_create_key_pair().await?; |
There was a problem hiding this comment.
secP in this case - in new code, I used key, private_key and public_key for our "main" keys (secp) and if it's rsa, I tried to call them rsa_keys, rsa_public_key etc. as a convention.
This would be consistent with that, but we'd have to change it once across the whole codebase to be really clean.
📝 Description
Enables the notification service via Nostr. As this is breaking until we have a dev relay I keep it as a draft PR.
Relates to #119 #244
✅ Checklist
Please ensure the following tasks are completed before requesting a review:
cargo fmt.🚀 Changes Made
New Features:
Other Changes:
💡 How to Test
Please provide clear instructions on how reviewers can test your changes:
🤝 Related Issues
List any related issues, pull requests, or discussions:
🔗 Additional Context (optional)
Until we have a dev relay this will break clients that have no access to a relay
📋 Review Guidelines