Spell Groups: Adapt revscript loading to spell groups #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous PR should've fixed XML loading, this should fix Revscript loading. I dont like how I created new enum, so this needs both testing and thought how it can be improved.
...meaning if spell was group none, but someone set group cooldown to it, the condition would put "global" cd on everything.
|
Needs: |
|
@Codinablack tested by @Silba93 and confirmed to be compiling and working in-game. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous PR (#32) should've adapted XML loading, this should adapt Revscript loading to stop forcing spells to have a group.