JNG-6219 fix link row delete transformation

[noherczeg]

No description provided.

[coderabbitai]

Error: Could not generate a valid Mermaid diagram after multiple attempts.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 69e1520 and 5684929.

📒 Files selected for processing (4)

• judo-tatami-jsl-jsl2ui/src/main/epsilon/transformations/ui/modules/view/menuLinkDeclarationViewPage.etl (1 hunks)
• judo-tatami-jsl-jsl2ui/src/main/epsilon/transformations/ui/modules/view/menuTableDeclarationViewPage.etl (1 hunks)
• judo-tatami-jsl-jsl2ui/src/main/epsilon/transformations/ui/modules/view/viewLinkDeclarationViewPage.etl (1 hunks)
• judo-tatami-jsl-jsl2ui/src/main/epsilon/transformations/ui/modules/view/viewTableDeclarationViewPage.etl (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: ⏳ Build, test and deploy artifacts

🔇 Additional comments (4)

judo-tatami-jsl-jsl2ui/src/main/epsilon/transformations/ui/modules/view/viewTableDeclarationViewPage.etl (1)

41-41: Added conditional check to prevent delete action for button links

The modification adds an additional condition and not link.button to prevent the row delete action from being added when the link represents a button. This change is aligned with the PR objective to fix link row delete transformation.

The change ensures consistency in the UI behavior by only allowing row deletion when appropriate (deletion is allowed and the link is not a button). This should resolve issues where delete actions were incorrectly appearing for button links.

judo-tatami-jsl-jsl2ui/src/main/epsilon/transformations/ui/modules/view/menuLinkDeclarationViewPage.etl (1)

43-45: Adds consistency in delete action handling for links with buttons

The change properly adds a condition to prevent the delete action from being generated when a link has a button property set. This brings the delete action logic in line with the refresh action handling (lines 33-38) which already differentiates between links with and without buttons.

This fix ensures that link row delete transformations are only applied in appropriate contexts, preventing potential issues with delete actions appearing in button-based links where they shouldn't be accessible.

judo-tatami-jsl-jsl2ui/src/main/epsilon/transformations/ui/modules/view/menuTableDeclarationViewPage.etl (1)

44-44: Added condition to prevent row delete actions on button links.

The change adds an additional condition and not link.button to only allow delete actions on links that are not buttons. This modification aligns with the PR objective to fix link row delete transformation.

This change correctly prevents the system from adding delete actions for button-type links, even when the underlying relation allows deletion. The fix maintains proper UI behavior by ensuring delete functionality is only available in appropriate contexts.

judo-tatami-jsl-jsl2ui/src/main/epsilon/transformations/ui/modules/view/viewLinkDeclarationViewPage.etl (1)

41-41: Good fix for preventing delete actions on button links.

The change prevents row delete actions from being added when a link has a button, aligning with the PR objective to fix link row delete transformation. This is an important improvement that ensures UI consistency by preventing delete actions on button links, which should only trigger their associated behavior.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.