JNG-6072 dialog from row lifecycle (#499)

BlackBeltTechnology · Dec 17, 2024 · dfc345a · dfc345a
1 parent ec9085d
commit dfc345a
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/...napshots/frontend-react/src/dialogs/View/Galaxy/Stars/RelationViewPage/index.tsx.snapshot b/...napshots/frontend-react/src/dialogs/View/Galaxy/Stars/RelationViewPage/index.tsx.snapshot
@@ -665,7 +665,12 @@ export default function ViewGalaxyStarsRelationViewPage(props: ViewGalaxyStarsRe
     if (rootPageId && dataPath && isDraft) {
       subscriptionRef.current = subscribe(`${rootPageId}:refreshed`, async (freshRootData: any) => {
         const copy = simpleCloneDeep(getValue<ViewStarStored>(freshRootData, dataPath!)!);
-        setData(copy);
+        if (copy !== undefined && copy !== null) {
+          // There are edge cases, e.g. when a row is opened in a dialog and an operation causes the row
+          // to be removed from the original table. In cases when the instance coming from a relation
+          // effectively gets removed we cannot null out our local data, because it results in the page crashing.
+          setData(copy);
+        }
       });
     }
 

diff --git a/judo-ui-react/src/main/resources/actor/src/dialogs/index.tsx.hbs b/judo-ui-react/src/main/resources/actor/src/dialogs/index.tsx.hbs
@@ -387,7 +387,12 @@ export default function {{ pageName page }}(props: {{ pageName page }}Props) {
         if (rootPageId && dataPath && isDraft) {
           subscriptionRef.current = subscribe(`${rootPageId}:refreshed`, async (freshRootData: any) => {
             const copy = simpleCloneDeep(getValue<{{ dialogDataType page }}>(freshRootData, dataPath!)!);
-            setData(copy);
+            if (copy !== undefined && copy !== null) {
+              // There are edge cases, e.g. when a row is opened in a dialog and an operation causes the row
+              // to be removed from the original table. In cases when the instance coming from a relation
+              // effectively gets removed we cannot null out our local data, because it results in the page crashing.
+              setData(copy);
+            }
           });
         }