Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO_NOT_MERGE] JNG-5152 enabled more relation actions #213

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

noherczeg
Copy link
Contributor

@noherczeg noherczeg commented Aug 28, 2023

StoryJNG-5152 Support relation CRUD with container create/update on UI

Ticket will have multiple PR-s, this is the first one.

No transaction has been hurt in the making of this change!

Changes:

Enabled Composition list create action in edit mode. Could work for create-in-create, couldn't test, but works on View

create-composition-mid-edit

Enabled Composition list delete action in edit mode. Even for newly created, "transient" elements.

delete-composition-in-edit

Since newly created elements don't have a signed id, pressing delete would've potentially removed the wrong item.
@noherczeg noherczeg changed the title JNG-5152 enabled more relation actions [DO_NOT_MERGE] JNG-5152 enabled more relation actions Aug 28, 2023
@noherczeg
Copy link
Contributor Author

Blocking merge because of missing features: validation propagation, and missing view/edit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants