JNG-6002 fix logo dimensions #483
Conversation
noherczeg
commented
Nov 4, 2024
•
noherczeg
commented
 JNG-6002 Fix application logo dimensions
|
noherczeg
requested review from
robertcsakany,
bencegelei,
gaborflorian and
Madmat8
WalkthroughThe changes introduce modifications to the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Outside diff range and nitpick comments (2)
judo-ui-react/src/main/resources/actor/src/layout/logo/LogoMain.tsx.hbs (1)
Line range hint
5-7: Clean up unused code.The
reverseprop and spread operator (...others) are not being used. Consider removing them if they're no longer needed. Also, the commented theme code suggests an incomplete dark/light mode implementation.-export const LogoMain = ({ reverse, ...others }: { reverse?: boolean }) => { - // const theme = useTheme(); // we an use theme in the future to detect light/dark modes +export const LogoMain = () => { const logoProps = useLogoProps();judo-ui-react/src/main/resources/actor/src/layout/Drawer/DrawerHeader.tsx.hbs (1)
39-40: LGTM! Symmetrical padding improves visual balance.The addition of
paddingRightthat mirrors thepaddingLeftlogic creates better visual symmetry in both horizontal and vertical orientations. This change complements the logo dimension fixes by ensuring consistent spacing around the logo.Consider extracting these common padding values into theme spacing tokens or constants if they're used across multiple components, making it easier to maintain consistent spacing throughout the application.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
judo-ui-react/src/main/resources/actor/src/layout/Drawer/DrawerHeader.tsx.hbs(1 hunks)judo-ui-react/src/main/resources/actor/src/layout/logo/LogoMain.tsx.hbs(1 hunks)
🔇 Additional comments (1)
judo-ui-react/src/main/resources/actor/src/layout/logo/LogoMain.tsx.hbs (1)
10-10: LGTM! The maxHeight change prevents logo distortion.
The switch from height to maxHeight is a good fix as it maintains the logo's aspect ratio while preventing overflow.
| @@ -7,6 +7,6 @@ export const LogoMain = ({ reverse, ...others }: { reverse?: boolean }) => { | |||
| const logoProps = useLogoProps(); | |||
|
|
|||
| return ( | |||
| <img src={logoProps.imgSrc} style={ { height: '100%', maxWidth: '100%' } } /> | |||
| <img src={logoProps.imgSrc} style={ { maxHeight: '100%', maxWidth: '100%' } } /> | |||
There was a problem hiding this comment.
Add alt text for accessibility.
The image lacks an alt attribute which is essential for accessibility. Screen readers need this to provide context to users.
- <img src={logoProps.imgSrc} style={ { maxHeight: '100%', maxWidth: '100%' } } />
+ <img
+ src={logoProps.imgSrc}
+ alt="Company Logo"
+ style={ { maxHeight: '100%', maxWidth: '100%' } }
+ />📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| <img src={logoProps.imgSrc} style={ { maxHeight: '100%', maxWidth: '100%' } } /> | |
| <img | |
| src={logoProps.imgSrc} | |
| alt="Company Logo" | |
| style={ { maxHeight: '100%', maxWidth: '100%' } } | |
| /> |
🛠️ Refactor suggestion
Add error handling for image load failures.
Consider adding an onError handler to gracefully handle cases where the logo fails to load.
- <img src={logoProps.imgSrc} style={ { maxHeight: '100%', maxWidth: '100%' } } />
+ <img
+ src={logoProps.imgSrc}
+ style={ { maxHeight: '100%', maxWidth: '100%' } }
+ onError={(e) => {
+ e.currentTarget.style.display = 'none';
+ console.error('Failed to load logo:', logoProps.imgSrc);
+ }}
+ />📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| <img src={logoProps.imgSrc} style={ { maxHeight: '100%', maxWidth: '100%' } } /> | |
| <img | |
| src={logoProps.imgSrc} | |
| style={ { maxHeight: '100%', maxWidth: '100%' } } | |
| onError={(e) => { | |
| e.currentTarget.style.display = 'none'; | |
| console.error('Failed to load logo:', logoProps.imgSrc); | |
| }} | |
| /> |
