JNG-6168 bump deps for missing translations #524
Conversation
noherczeg
requested review from
robertcsakany,
bencegelei,
gaborflorian and
Madmat8
WalkthroughThe changes update dependency versions in two configuration files of the UI React project. In the dependency fragment file, versions for several MUI packages (data grid, date pickers, tree view, and license) have been bumped from 7.23.6 to newer releases (7.27.2, 7.27.1, and 7.26.0) with a condition for the license update. In the pnpm-lock file, similar updates are applied to both standard and pro versions of MUI packages along with an update to internal dependencies and the addition of a new dependency, Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
judo-ui-react/src/main/resources/actor/package.json.dependencies.fragment.hbs (1)
10-11: Consider synchronizing version numbers for better maintainability.I notice that the various MUI X components are now using slightly different version numbers (7.27.2 for data-grid, 7.27.1 for date-pickers). While this may be intentional to target specific fixes, consider whether aligning these versions would simplify future maintenance.
judo-ui-react/src/main/resources/actor/pnpm-lock.pro.yaml (2)
39-49: Updated MUI X Dependencies in ImportersThe dependency versions for several MUI X packages have been updated in the importers block:
- @mui/x-data-grid-pro now uses specifier
7.27.2- @mui/x-date-pickers-pro now uses specifier
7.27.1- @mui/x-license now uses specifier
7.26.0- @mui/x-tree-view now uses specifier
7.26.0Please verify that these bumps are consistent with your package dependency fragment (e.g. in your package.json template) and that any breaking changes introduced by the updated versions have been addressed in the UI.
1831-1835: Addition of New Dependency: [email protected]A new dependency
use-sync-external-storehas been added at version1.4.0, with the appropriate peer dependency on React (^16.8.0 || ^17.0.0 || ^18.0.0 || ^19.0.0). Please ensure that this addition is intentional, that it integrates correctly within your project code, and that any new usage is covered by tests or documentation updates.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
judo-ui-react/src/main/resources/actor/pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (2)
judo-ui-react/src/main/resources/actor/package.json.dependencies.fragment.hbs(1 hunks)judo-ui-react/src/main/resources/actor/pnpm-lock.pro.yaml(12 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: ⏳ Build, test and deploy artifacts
🔇 Additional comments (4)
judo-ui-react/src/main/resources/actor/package.json.dependencies.fragment.hbs (3)
10-13:❓ Verification inconclusive
Check dependency tree for potential conflicts.
When updating packages to newer versions, it's important to verify that there are no conflicts with other dependencies. The lock file update mentioned in the summary should handle this, but it's worth confirming that the application builds and runs correctly with these new versions.
🏁 Script executed:
#!/bin/bash # Determine if there's a package.json file in the same directory to check find judo-ui-react/src/main/resources/actor -name "package.json" -type fLength of output: 72
Dependency Tree Verification – Manual Review Required
The updated dependency fragment appears correct. However, our automated search didn’t locate a
package.jsonfile in thejudo-ui-react/src/main/resources/actordirectory, so we couldn’t automatically verify that the lock file update prevents conflicts. Please manually confirm that the application builds and runs as expected, ensuring there are no dependency conflicts when using the updated versions.
- File under review:
judo-ui-react/src/main/resources/actor/package.json.dependencies.fragment.hbs- Snippet:
Please verify the dependency tree and build/run processes manually to ensure compatibility with the new versions.
13-13:❓ Verification inconclusive
Verify the conditional license dependency.
The MUI X license dependency is conditionally included based on
isMUILicensedflag. Ensure this flag is correctly set in your build environment, as it's crucial for proper license validation in production.
🏁 Script executed:
#!/bin/bash # Look for where isMUILicensed is defined or set in the codebase rg -A 2 -B 2 "isMUILicensed" --glob "!*.lock*" --glob "!*node_modules*"Length of output: 4025
Verify MUI License Configuration
The conditional inclusion of the "@mui/x-license" dependency in the package.json fragment is based on theisMUILicensedflag. Our search confirms that this flag is referenced consistently across the codebase—in both the Handlebars template and within the TSX and Java files (e.g., inReactStoredVariableHelper.javaandvite-env.d.ts.hbs). Please ensure that:
- The build environment correctly sets the MUI license configuration (e.g., via the
VITE_MUI_LICENSE_KEYin your environment and the logic ingetMUILicensePlan()).- All conditional inclusion points (in
package.json.dependencies.fragment.hbsandsrc/main.tsx.hbs) operate as intended in production to validate the license properly.
10-13:❓ Verification inconclusive
Dependency version updates look appropriate.
The MUI X components have been updated to newer versions which should address the missing translations issue mentioned in the PR title. The version increments are relatively minor (from 7.23.6 to versions between 7.26.0 and 7.27.2) and should be backward compatible.
🌐 Web query:
What are the changes between MUI X version 7.23.6 and 7.27.2?💡 Result:
Between MUI X versions 7.23.6 and 7.27.2, several improvements, bug fixes, and minor breaking changes were introduced across Data Grid, Date Pickers, and Charts components. Here are the key updates:
Data Grid Changes
- Excel Export Enhancements: Improved serialization performance and fixed Web Worker demo issues in development mode [7][10].
- New Props: Added
resetPageOnSortFilterto reset pagination after sorting/filtering [7].- Pagination Fixes: Addressed unexpected behavior when using "-1" for "All" rows and ensured consistent server-side data navigation [7][9].
- TypeScript Changes:
GridSortModelbecame a readonly array (breaking change for direct mutations) [7][9].rowCountin pagination no longer acceptsundefined[7].- Rendering & Behavior:
- Fixed
renderContextcalculation with scroll bounce [7].- Improved header filter keyboard navigation and toolbar button
onClickorder [7].- Localization: Added Bangla (bn-BD) and improved Hungarian (hu-HU), Russian (ru-RU), Polish (pl-PL), and Ukrainian (uk-UA) locales [7][10].
Date and Time Pickers
- Mobile Fixes: Corrected
currentMonthCalendarPositionbehavior and vertical alignment in multi-input Date Range Pickers [7].Charts
- Pie Chart Fix: Resolved empty series array handling [7].
- Line Chart: Enabled default animations (disablable via
skipAnimation) [4].Breaking Changes
- Type Safety:
GridSortModelnow uses a readonly array type, requiring updates to mutation logic [9].- Webpack 5 Requirement: Dropped Webpack 4 support due to native browser feature usage (e.g., Optional Chaining) [4].
Performance & Stability
- Mount/Resize Optimizations: Reduced Data Grid rendering latency [7].
- State Management: Refactored row state propagation for consistency [7].
Other
- Core Dependencies: Updated
@mui/materialpeer dependency to^5.15.14for Charts [4].For migration, run codemods (
npx @mui/x-codemod@latest v7.0.0/preset-safe) and review type changes inGridSortModel[1][7][9].Citations:
- 1: https://mui.com/x/migration/migration-data-grid-v6/
- 2: https://classic.yarnpkg.com/en/package/@mui/x-data-grid-generator
- 3: https://refine.dev/docs/ui-integrations/material-ui/migration-guide/material-ui-v5-to-v6/
- 4: https://mui.com/x/migration/migration-charts-v6/
- 5: https://mui.com/x/whats-new/
- 6: https://www.spp.org/documents/14938/1007e0048%2036%20-%20%20mui%20xml%20interface%20spec.pdf
- 7: https://github.com/mui/mui-x/releases
- 8: https://www.npmjs.com/package/@mui/x-data-grid
- 9: [data grid] Upgrading from data-grid 7.27.1 to 7.27.2 breaks code using GridSortModel mui/mui-x#16760
- 10: https://newreleases.io/project/npm/@mui/x-data-grid-pro/release/7.27.2
Verified MUI X Dependency Update – Minor API Adjustments Not Impacting This File
The updates in the dependency fragment are consistent with the migration path from v7.23.6 to the current versions. As confirmed by the release notes, the new versions for
@mui/x-data-grid(7.27.2),@mui/x-date-pickers(7.27.1), and@mui/x-tree-view(7.26.0) introduce several bug fixes, enhancements, and some minor API changes (for example, GridSortModel is now a readonly array). These changes primarily address issues like the missing translations noted in the PR title and should not affect usage within this file, provided any required codemods for breaking changes are applied.
- File:
judo-ui-react/src/main/resources/actor/package.json.dependencies.fragment.hbs(Lines 10-13)Overall, the dependency updates are appropriate and align with our migration goals.
judo-ui-react/src/main/resources/actor/pnpm-lock.pro.yaml (1)
857-2659: Comprehensive Bump of MUI‐Related Packages in the LockfileAcross the lockfile’s deeper sections (in the
packagesand snapshots sections), several entries for MUI-related packages have been updated:
- @mui/x-data-grid-pro and @mui/x-data-grid are now pinned to version
7.27.2- @mui/x-date-pickers-pro and @mui/x-date-pickers are updated to version
7.27.1- @mui/x-internals is bumped to
7.26.0- @mui/x-license and @mui/x-tree-view have been revised to
7.26.0These changes ensure consistency between the upgrade in your dependency fragment and the lockfile. Please run your full test suite to confirm that the updated versions work seamlessly with your codebase and that peer dependency constraints (especially on React) remain satisfied.
No description provided.