refactor: improve readability

BlackGlory · Jan 1, 2024 · 6d90eeb · 6d90eeb
1 parent f35a7e0
commit 6d90eeb
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/src/components/advanced-options.tsx b/src/components/advanced-options.tsx
@@ -23,7 +23,7 @@ export function AdvancedOptions({ rule, ruleIndex }: IAdvancedOptionsProps) {
           <section>
             <Checkbox
               value={rule.matchersEnabled}
-              onClick={enabled => updateConfig(config => {
+              onChange={enabled => updateConfig(config => {
                 config.rules![ruleIndex].matchersEnabled = enabled
               })}
             >
@@ -39,7 +39,7 @@ export function AdvancedOptions({ rule, ruleIndex }: IAdvancedOptionsProps) {
           <section>
             <Checkbox
               value={rule.fontWeightEnabled}
-              onClick={enabled => updateConfig(config => {
+              onChange={enabled => updateConfig(config => {
                 config.rules![ruleIndex].fontWeightEnabled = enabled
               })}
             >
@@ -58,7 +58,7 @@ export function AdvancedOptions({ rule, ruleIndex }: IAdvancedOptionsProps) {
           <section>
             <Checkbox
               value={rule.unicodeRangeEnabled}
-              onClick={enabled => updateConfig(config => {
+              onChange={enabled => updateConfig(config => {
                 config.rules![ruleIndex].unicodeRangeEnabled = enabled
               })}
             >

diff --git a/src/components/checkbox.tsx b/src/components/checkbox.tsx
@@ -1,17 +1,18 @@
 interface ICheckboxProps {
   value: boolean
   children: React.ReactNode
-  onClick: (value: boolean) => void
+
+  onChange: (value: boolean) => void
 }
 
-export function Checkbox({ value, children, onClick }: ICheckboxProps) {
+export function Checkbox({ value, children, onChange }: ICheckboxProps) {
   return (
     <label className='flex space-x-1 cursor-pointer'>
       <input
         className='border accent-gray-700'
         type='checkbox'
         checked={value}
-        onChange={e => onClick(e.target.checked)}
+        onChange={e => onChange(e.target.checked)}
       />
       <div>{children}</div>
     </label>