Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

categorization script #145

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

categorization script #145

wants to merge 18 commits into from

Conversation

hpatel1567
Copy link
Collaborator

Adding a new reaction categorization script.

Types of reactions so far:
redox, non_local_reaction_center, Li_coordination_Li+A_to_LiA, non_local_reaction_center_LiF_formning, coordination_change_within_molecule, LiF_coordinating, coord_and_covalent_bond_changes, LiF_hopping, Li_hopping, AutoTS, uncategorized

Looking for suggestions on improving update_rates_RNMC() method to also include nonconstant rates based on dG values.

@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2021

Codecov Report

Merging #145 (b9989b6) into main (b346791) will decrease coverage by 3.11%.
The diff coverage is 0.51%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #145      +/-   ##
==========================================
- Coverage   65.73%   62.62%   -3.12%     
==========================================
  Files          16       17       +1     
  Lines        3920     4115     +195     
==========================================
  Hits         2577     2577              
- Misses       1343     1538     +195     
Impacted Files Coverage Δ
src/mrnet/utils/reaction_category.py 0.00% <0.00%> (ø)
src/mrnet/utils/visualization.py 98.46% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b346791...b9989b6. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants