Added support for collections of simple types (i.e. List<string>) #237
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows @matthetherington 's implementation of PR #205 (for #204).
If you have a this model/validator:
field validation is not working. Validation summary shows the errors, but you cannot link them to validation messages.
Here's what I believe is happening:
AddressLines.0
AddressLines[0]
(same as the name tag if you useeditContext.ShouldUseFieldIdentifiers = true
)..Where(validationFailure => validationFailure.PropertyName == propertyPath)
failsAssuming this analysis is correct, you can either 1. change the PropertyPath to have the
AddressLines[0]
format or 2. change the validationResult.PropertyName to have theAddressLines.0
format. 1 is happening somewhere inside ValidateAsync, but I couldn't figure out where, so I went with 2.What I changed:
ToFieldIdentifier
in case there are no more tokens and the remaining property path ends with "]"I've done some testing, but I it's likely I'm missing some use cases.